JS-fix: test the existence of collection as well#20075
Merged
nielslyngsoe merged 2 commits intomainfrom Sep 5, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a JavaScript error by adding null safety to a type guard function. The change prevents potential runtime errors when accessing properties on a potentially undefined collection object.
- Adds optional chaining operator to prevent accessing properties on undefined objects
...Client/src/packages/content/content/collection/content-collection-workspace.context-token.ts
Show resolved
Hide resolved
madsrasmussen
approved these changes
Sep 5, 2025
nielslyngsoe
deleted the
v16/bugfix/fix-collection-condition-js-error
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing a minor mistake, to avoid js errors in console.