Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR deprecates the legacy Stylesheet Create Options modal and introduces an extensible entityCreateOptionAction approach for integrating third-party TinyMCE packages. Key changes include:
- Creation of a new UmbStylesheetCreateOptionAction for constructing stylesheet creation URLs.
- Deprecation of modal-related types and elements in favor of extension-based actions.
- Updates to manifests to register the new entity actions and mark legacy modal components as deprecated.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/entity-actions/create/stylesheet-create-option-action.ts | Added new entityCreateOptionAction with custom URL generation for stylesheet creation |
| src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/entity-actions/create/options-modal/stylesheet-create-options.modal-token.ts | Marked modal token interface as deprecated |
| src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/entity-actions/create/options-modal/stylesheet-create-options-modal.element.ts | Marked modal element as deprecated |
| src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/entity-actions/create/manifests.ts | Updated manifests to include the new entity actions and deprecate old modal registrations |
| src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/entity-actions/create/create.action.ts | Marked the existing create action as deprecated in favor of the new approach |
Comments suppressed due to low confidence (1)
src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/entity-actions/create/stylesheet-create-option-action.ts:6
- Consider verifying the use of the string 'null' as a fallback for this.args.unique. Confirm that this behavior meets the intended URL structure when the unique identifier is missing.
const href = `section/settings/workspace/stylesheet/create/parent/${this.args.entityType}/${this.args.unique || 'null'}`;
to resolve failing acceptance test.
|
Note
|
|
@andr317c Tagging you for review of updates to |
Description
Following on from the removal of RTE Stylesheets #18908, we need a way for a 3rd-party TinyMCE package can re-introduce RTE Stylesheets, we needed the Stylesheet Create menu to be powered by
entityCreateOptionActionextensions.This PR deprecates the "Stylesheet Create Options modal" (which had hardcoded options; for removal in v18), replacing it with the extensible
entityCreateOptionActionoptions.