V16: Removes RTE Stylesheets (client-side)#18908
Merged
iOvergaard merged 6 commits intov16/devfrom Apr 2, 2025
Merged
Conversation
with the Scripts code editor.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request removes all client-side references to the redundant RTE (Rich Text Editor) Stylesheet feature. Key changes include:
- Complete removal of manifests, constants, and module exports related to the RTE Stylesheet.
- Updates to the stylesheet creation options modal to replace RTE-specific actions with a generic stylesheet creation flow.
- Removal of all RTE Stylesheet language keys from localization files.
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/global-components/stylesheet-rule-input/manifests.ts | Removed RTE-related modal manifest registration. |
| src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/global-components/stylesheet-rule-input/constants.ts | Removed constants for RTE stylesheet settings. |
| src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/global-components/manifests.ts | Removed import and export of RTE stylesheet manifests. |
| src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/global-components/index.ts | Removed imports and exports for obsolete stylesheet rule components. |
| src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/global-components/constants.ts | Updated exports to no longer include RTE stylesheet constants. |
| src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/entity-actions/create/options-modal/stylesheet-create-options-modal.element.ts | Updated modal options to remove the RTE-specific creation link and utilize localized strings. |
| src/Umbraco.Web.UI.Client/src/mocks/data/stylesheet/stylesheet.data.ts | Removed mock stylesheet rules that referenced RTE styles. |
| Various localization files (tr-tr.ts, nl-nl.ts, it-it.ts, hr-hr.ts, fr-fr.ts, en.ts, en-us.ts, de-de.ts, da-dk.ts, cy-gb.ts, cs-cz.ts, bs.ts, ar.ts) | Removed keys related to the RTE Stylesheet to reflect the updated functionality. |
iOvergaard
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following on from the TinyMCE removal (client-side) #18889, the RTE Stylesheet feature has become redundant, and has been removed from the client-side codebase.
Note
Since the create New Rich Text Editor Stylesheet option has been removed from the Stylesheet create modal, we will need to implement an
entityCreateOptionAction-powered menu for Stylesheets, so that a 3rd-party TinyMCE package can re-introduce this feature.