V16: Update Stylesheet Create button locator#224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With updates made in umbraco/Umbraco-CMS#18911, the acceptance tests were failing.
I needed to update the locator for "New Stylesheet" button, making use of the
createOptionActionListModallocator in the base class, to align with Data Type and Media Type create option actions modal.Note
I have incremented the version number to 16.0.0, to align with the Umbraco CMS version, and set the target branch to be
v16/dev. The reason for this is that the Stylesheets Create Options markup have not changed in Umbraco CMS v15.x, so the acceptance tests need to target the v16 helper library.