Add contentTypeEditor to editorService#15034
Add contentTypeEditor to editorService#15034nul800sebastiaan merged 4 commits intoumbraco:contribfrom
Conversation
|
Hi there @bjarnef, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
|
Hi @bjarnef , Thanks for your PR! A member of the Core Collaborators team will have a look at it soon! |
src/Umbraco.Web.UI.Client/src/common/services/editor.service.js
Outdated
Show resolved
Hide resolved
| */ | ||
| function contentTypeEditor(editor) { | ||
|
|
||
| if (!editor.entityType) editor.entityType = "documentType"; |
There was a problem hiding this comment.
Default to documentType to keep it consistent with: #15080
|
Good stuff @bjarnef - thanks very much! 👍 |
Prerequisites
Description
Follow-up on #15017 to make it a bit simple to open content type editor and reduce some of the same logic based on content type.
I think it could also be useful to (package) developers.
Relates to #15080