Skip to content

Add contentTypeEditor to editorService#15034

Merged
nul800sebastiaan merged 4 commits intoumbraco:contribfrom
bjarnef:feature/editorservice-content-type-editor
Nov 30, 2023
Merged

Add contentTypeEditor to editorService#15034
nul800sebastiaan merged 4 commits intoumbraco:contribfrom
bjarnef:feature/editorservice-content-type-editor

Conversation

@bjarnef
Copy link
Copy Markdown
Contributor

@bjarnef bjarnef commented Oct 24, 2023

Prerequisites

  • I have added steps to test this contribution in the description below

Description

Follow-up on #15017 to make it a bit simple to open content type editor and reduce some of the same logic based on content type.

I think it could also be useful to (package) developers.

Relates to #15080

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 24, 2023

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@mikecp
Copy link
Copy Markdown
Contributor

mikecp commented Oct 26, 2023

Hi @bjarnef ,

Thanks for your PR! A member of the Core Collaborators team will have a look at it soon!

*/
function contentTypeEditor(editor) {

if (!editor.entityType) editor.entityType = "documentType";
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default to documentType to keep it consistent with: #15080

@nul800sebastiaan
Copy link
Copy Markdown
Member

Good stuff @bjarnef - thanks very much! 👍

@bjarnef bjarnef deleted the feature/editorservice-content-type-editor branch November 30, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants