Adjust content type picker to support different content types#15080
Adjust content type picker to support different content types#15080nul800sebastiaan merged 3 commits intoumbraco:contribfrom
Conversation
|
Hi there @bjarnef, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
| */ | ||
| function contentTypePicker(editor) { | ||
|
|
||
| if (!editor.entityType) editor.entityType = "documentType"; |
There was a problem hiding this comment.
We need to make documentType default as it is the current behaviour.
|
I think we could simplify this part a bit to use the Update: simplified in 291adc4 - it could also just explicit use |
|
Hi @bjarnef! Thanks for your PR relating to #15034, to adjust the content type picker to support different content types. One of the Core Collaborators team will review this as soon as possible - it also seems like one that we might want HQ to review, so we will likely need to contact them about it. Best wishes Emma |
|
And related to merging #15034 - this one is great too, thanks again! |
Prerequisites
Description
Adjust
editorServiceto have a dedicateddocumentTypePicker, while the current allow specifying entity type, but fallback todocumentTypewhich is current behaviour and to avoid a breaking change.This also streamline the concept that content type is both content, media and member type, while document type is more specific.
Related to #15034