Skip to content

Adjust content type picker to support different content types#15080

Merged
nul800sebastiaan merged 3 commits intoumbraco:contribfrom
bjarnef:patch-6
Nov 30, 2023
Merged

Adjust content type picker to support different content types#15080
nul800sebastiaan merged 3 commits intoumbraco:contribfrom
bjarnef:patch-6

Conversation

@bjarnef
Copy link
Copy Markdown
Contributor

@bjarnef bjarnef commented Nov 1, 2023

Prerequisites

  • I have added steps to test this contribution in the description below

Description

Adjust editorService to have a dedicated documentTypePicker, while the current allow specifying entity type, but fallback to documentType which is current behaviour and to avoid a breaking change.

This also streamline the concept that content type is both content, media and member type, while document type is more specific.

Related to #15034

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 1, 2023

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@bjarnef bjarnef changed the title Adjust content type picker Adjust content type picker to support different content types Nov 1, 2023
*/
function contentTypePicker(editor) {

if (!editor.entityType) editor.entityType = "documentType";
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make documentType default as it is the current behaviour.

@bjarnef
Copy link
Copy Markdown
Contributor Author

bjarnef commented Nov 1, 2023

I think we could simplify this part a bit to use the contentTypePicker instead of treePicker.

https://github.com/umbraco/Umbraco-CMS/blob/contrib/src/Umbraco.Web.UI.Client/src/views/propertyeditors/blocklist/prevalue/blocklist.blockconfiguration.controller.js#L106-L145

Update: simplified in 291adc4 - it could also just explicit use documentTypePicker.

@emmagarland
Copy link
Copy Markdown
Collaborator

Hi @bjarnef!

Thanks for your PR relating to #15034, to adjust the content type picker to support different content types.

One of the Core Collaborators team will review this as soon as possible - it also seems like one that we might want HQ to review, so we will likely need to contact them about it.

Best wishes

Emma

@nul800sebastiaan
Copy link
Copy Markdown
Member

And related to merging #15034 - this one is great too, thanks again!

@bjarnef bjarnef deleted the patch-6 branch November 30, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants