Bug fix for compistion on member and media give 404

[rammi987]

Prerequisites

• I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes
#15009

Description

1. add a new media type or member type
2. go to exiting media type or member type
3. Add the created media type og member from step 1 as a compisition
4. save the type
5. Click on the inhrite link, and see the composition media type or member type open as expteced instead of throw 404

The solution is simple and work without any compromise made, the code is taken from what is allerede done, in the code here:

Umbraco-CMS/src/Umbraco.Web.UI.Client/src/views/dataTypes/views/datatype.info.controller.js

Line 74 in f8b66aa

switch (type) {

[github-actions]

Hi there @rammi987, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[mikecp]

Thanks @rammi987 for this fix!

A member of the core collaborators team will have a look at it soon 😁

[emmagarland]

Hi @rammi987, thanks so much for your pull request to fix the issue of compositions with media types and member types returning a 404 when linking to them (#15009).

I've just replicated this and can confirm that your fix resolves it!

I will merge this PR. The only other minor suggestion I might have had is to refactor the method into a shared method (since it is very similar in two places), but this isn't vital.

It has now been successfully merged 🙌 It is targeted for release v13.0.0

Finally, I've marked this PR with the project/bellisima label so that we will remember to revisit this feature for Bellissima as well. You're welcome to have a look at creating an equivalent PR for the new backoffice v14 as well if relevant, but if not then it's a reminder for the HQ team to implement the same functionality before new backoffice gets released.

Best wishes

Emma