Info panes not loading prerequisites#13486
Merged
iOvergaard merged 2 commits intorelease/11.0from Nov 29, 2022
Merged
Conversation
iOvergaard
changed the title
nielslyngsoe
approved these changes
Nov 29, 2022
iOvergaard
added a commit
that referenced
this pull request
Dec 1, 2022
* load relations immediately on init and remove call to non-existing function `appTabChange` on destroy * load relations immediately on init and remove now not-used eventsService
nikolajlauridsen
added a commit
that referenced
this pull request
Dec 1, 2022
* update marketplace url to its final, live url * Added various Block Grid translations (EN & NL) (#13488) * Added various translations * Added another translation * Change request * Revert breaking changes adding IContextCache to deploy connectors (#13489) * Remove breaking changes in Deploy connector interfaces * Add extension methods for calling the new interface methods in a backwards-compatible way * Create and pack empty file to add TFM dependency (#13475) * Change login image to new SVG. (#13493) * Only add global usings when ImplicitUsings is enabled (#13491) * bump to rc6 * V11: Allow changing logging directory from configuration (#13485) * Allow changing logging directory from configuration * Clean up * Missing return statement * Apply suggestions from code review Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com> * Update src/Umbraco.Core/Constants-SystemDirectories.cs Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com> Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com> * Move login.svg file * Make sure contexbar fits within the available space (#13467) * Make sure contexbar fits within the available space * Ensuring context bar moves above, no matter size of it. * Fixing apperance of connection-fixers * Info panes not loading prerequisites (#13486) * load relations immediately on init and remove call to non-existing function `appTabChange` on destroy * load relations immediately on init and remove now not-used eventsService * do not set layout gaps (#13496) * Nuget updates (#13478) * Updated nuget packages * Remove npoco update Co-authored-by: nikolajlauridsen <nikolajlauridsen@protonmail.ch> * Nuget updates (#13478) * Updated nuget packages * Remove npoco update Co-authored-by: nikolajlauridsen <nikolajlauridsen@protonmail.ch> * Bump version to final * V11/cherry pick flaky test (#13506) * V10/feature/fixing flaky acceptance test (#13473) * Bumped version * Handle external authentication providers (#13487) Co-authored-by: Jacob Overgaard <752371+iOvergaard@users.noreply.github.com> Co-authored-by: Corné Hoskam <choskam@hotmail.com> Co-authored-by: Ronald Barendse <ronald@barend.se> Co-authored-by: Niels Lyngsø <nsl@umbraco.dk> Co-authored-by: Bjarke Berg <mail@bergmania.dk> Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com> Co-authored-by: nikolajlauridsen <nikolajlauridsen@protonmail.ch> Co-authored-by: Andreas Zerbst <73799582+andr317c@users.noreply.github.com>
bergmania
added a commit
that referenced
this pull request
Dec 7, 2022
* v11: Umbraco Marketplace replaces packages repo (#13371) * add lang keys for marketplace * remove old 'repo' page and deprecate related services * add new view for Umbraco Marketplace * optimise margin/padding for other tabs * mark Our Repository constants as obsolete * improve css path to iframe slightly with more aliases and classnames * remove style qs * update URL of Marketplace * add ng-controller with utitlities for future PostMessage API * rename marketplace loaded function * remove iframe postmessage logic for time being * add handling of dynamic querystring params * assume url does not change * Added support for additional parameters for marketplace * Update src/JsonSchema/AppSettings.cs Fix styling issue Co-authored-by: Ronald Barendse <ronald@barend.se> * Update src/Umbraco.Core/Configuration/Models/MarketplaceSettings.cs Fix styling issue Co-authored-by: Ronald Barendse <ronald@barend.se> * Update src/Umbraco.Core/Configuration/Models/MarketplaceSettings.cs Make comment more descriptive Co-authored-by: Ronald Barendse <ronald@barend.se> * Update src/Umbraco.Core/Constants-Marketplace.cs Fix styling issue Co-authored-by: Ronald Barendse <ronald@barend.se> Co-authored-by: Bjarke Berg <mail@bergmania.dk> Co-authored-by: Ronald Barendse <ronald@barend.se> * Info panes not loading prerequisites (#13486) * load relations immediately on init and remove call to non-existing function `appTabChange` on destroy * load relations immediately on init and remove now not-used eventsService * update marketplace url to its final, live url * re-add files to prevent breaking change Co-authored-by: Bjarke Berg <mail@bergmania.dk> Co-authored-by: Ronald Barendse <ronald@barend.se>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Fixes #13479
Description
Following the change of loading subviews conditionally with
ng-if, some subviews were dependent on a global event called "app.tabChange", which still works but was now being fired too early since the components are now only loaded on demand. The same logic now makes it possible to just invoke the prerequisites for each subview directly on init, since it's only loaded if it's visible.