v11: Umbraco Marketplace replaces packages repo#13371
Conversation
ronaldbarendse
left a comment
There was a problem hiding this comment.
I've added some suggestions to fix minor styling issues and comments.
Regarding the URL that's requested, maybe we should construct the URL based on the installed version, so the Marketplace can redirect to the appropriate page, e.g. https://[dev.]marketplace.umbraco.com/backoffice/[version]?
For now, that could redirect to https://[dev.][marketplace.umbraco.com/?version=[version]&style=backoffice, but allow overriding later. This could also be used to redirect an EOL version to a 'version unsupported' page, etc.
Regarding the additional parameters: adding them to the query string might result in issues with URL lengths and exposing sensitive information (as query strings might end up in HTTP logs, etc.). Maybe a better approach is to post a message to the Marketplace iframe using window.postMessage()?
marketplaceIframe.postMessage({
"additionalDataKey1": "additionalDataValue1",
"additionalDataKey2": "additionalDataValue2"
}, "https://[dev.][marketplace.umbraco.com/");Fix styling issue Co-authored-by: Ronald Barendse <ronald@barend.se>
Fix styling issue Co-authored-by: Ronald Barendse <ronald@barend.se>
Make comment more descriptive Co-authored-by: Ronald Barendse <ronald@barend.se>
Fix styling issue Co-authored-by: Ronald Barendse <ronald@barend.se>
…Umbraco-CMS into v11/feature/marketplace
* add lang keys for marketplace * remove old 'repo' page and deprecate related services * add new view for Umbraco Marketplace * optimise margin/padding for other tabs * mark Our Repository constants as obsolete * improve css path to iframe slightly with more aliases and classnames * remove style qs * update URL of Marketplace * add ng-controller with utitlities for future PostMessage API * rename marketplace loaded function * remove iframe postmessage logic for time being * add handling of dynamic querystring params * assume url does not change * Added support for additional parameters for marketplace * Update src/JsonSchema/AppSettings.cs Fix styling issue Co-authored-by: Ronald Barendse <ronald@barend.se> * Update src/Umbraco.Core/Configuration/Models/MarketplaceSettings.cs Fix styling issue Co-authored-by: Ronald Barendse <ronald@barend.se> * Update src/Umbraco.Core/Configuration/Models/MarketplaceSettings.cs Make comment more descriptive Co-authored-by: Ronald Barendse <ronald@barend.se> * Update src/Umbraco.Core/Constants-Marketplace.cs Fix styling issue Co-authored-by: Ronald Barendse <ronald@barend.se> Co-authored-by: Bjarke Berg <mail@bergmania.dk> Co-authored-by: Ronald Barendse <ronald@barend.se>
* add lang keys for marketplace * remove old 'repo' page and deprecate related services * add new view for Umbraco Marketplace * optimise margin/padding for other tabs * mark Our Repository constants as obsolete * improve css path to iframe slightly with more aliases and classnames * remove style qs * update URL of Marketplace * add ng-controller with utitlities for future PostMessage API * rename marketplace loaded function * remove iframe postmessage logic for time being * add handling of dynamic querystring params * assume url does not change * Added support for additional parameters for marketplace * Update src/JsonSchema/AppSettings.cs Fix styling issue Co-authored-by: Ronald Barendse <ronald@barend.se> * Update src/Umbraco.Core/Configuration/Models/MarketplaceSettings.cs Fix styling issue Co-authored-by: Ronald Barendse <ronald@barend.se> * Update src/Umbraco.Core/Configuration/Models/MarketplaceSettings.cs Make comment more descriptive Co-authored-by: Ronald Barendse <ronald@barend.se> * Update src/Umbraco.Core/Constants-Marketplace.cs Fix styling issue Co-authored-by: Ronald Barendse <ronald@barend.se> Co-authored-by: Bjarke Berg <mail@bergmania.dk> Co-authored-by: Ronald Barendse <ronald@barend.se>
* v11: Umbraco Marketplace replaces packages repo (#13371) * add lang keys for marketplace * remove old 'repo' page and deprecate related services * add new view for Umbraco Marketplace * optimise margin/padding for other tabs * mark Our Repository constants as obsolete * improve css path to iframe slightly with more aliases and classnames * remove style qs * update URL of Marketplace * add ng-controller with utitlities for future PostMessage API * rename marketplace loaded function * remove iframe postmessage logic for time being * add handling of dynamic querystring params * assume url does not change * Added support for additional parameters for marketplace * Update src/JsonSchema/AppSettings.cs Fix styling issue Co-authored-by: Ronald Barendse <ronald@barend.se> * Update src/Umbraco.Core/Configuration/Models/MarketplaceSettings.cs Fix styling issue Co-authored-by: Ronald Barendse <ronald@barend.se> * Update src/Umbraco.Core/Configuration/Models/MarketplaceSettings.cs Make comment more descriptive Co-authored-by: Ronald Barendse <ronald@barend.se> * Update src/Umbraco.Core/Constants-Marketplace.cs Fix styling issue Co-authored-by: Ronald Barendse <ronald@barend.se> Co-authored-by: Bjarke Berg <mail@bergmania.dk> Co-authored-by: Ronald Barendse <ronald@barend.se> * Info panes not loading prerequisites (#13486) * load relations immediately on init and remove call to non-existing function `appTabChange` on destroy * load relations immediately on init and remove now not-used eventsService * update marketplace url to its final, live url * re-add files to prevent breaking change Co-authored-by: Bjarke Berg <mail@bergmania.dk> Co-authored-by: Ronald Barendse <ronald@barend.se>
This replaces the packages repo in the 'Packages' section and marks the factory ourPackageRepositoryResource as deprecated. We are now showing an iframe with Umbraco Marketplace.
Screenshot of the frontpage of Marketplace:
Interaction with Marketplace + showing the other tabs not being affected:
2022-11-03.at.13.39.47.-.Silver.Lemur.mp4