Skip to content

New login background as SVG#13493

Merged
bergmania merged 1 commit intov11/devfrom
v11/feature/login-background-v11-svg
Nov 28, 2022
Merged

New login background as SVG#13493
bergmania merged 1 commit intov11/devfrom
v11/feature/login-background-v11-svg

Conversation

@nielslyngsoe
Copy link
Copy Markdown
Member

@nielslyngsoe nielslyngsoe commented Nov 28, 2022

New login background for v.11 as an SVG.

I kept the old JPG, so it's still there if referenced by some(?)

Notice, this must be cherry-picked for 11.0 branch.

@nielslyngsoe nielslyngsoe requested review from Zeegaan and nikolajlauridsen and removed request for nikolajlauridsen November 28, 2022 18:33
@bergmania bergmania merged commit 188fa23 into v11/dev Nov 28, 2022
@bergmania bergmania deleted the v11/feature/login-background-v11-svg branch November 28, 2022 18:55
bergmania pushed a commit that referenced this pull request Nov 28, 2022
@ronaldbarendse
Copy link
Copy Markdown
Contributor

ronaldbarendse commented Nov 28, 2022

@bergmania Please note that Umbraco 10 only had a custom installer background (see PR #12291), which this PR doesn't replace/update and left the login background to a more generic/muted blue with coloured shapes...

@nielslyngsoe All other static assets are placed within the Umbraco.Web.UI.Client project (and copied as part of the npm build script): what's the reason for adding the new background directly to the static assets RCL?

@bergmania
Copy link
Copy Markdown
Member

@ronaldbarendse, the intension is to update the background on each major. Like it changed on minors in the v7 timeperiod.

@ronaldbarendse
Copy link
Copy Markdown
Contributor

@ronaldbarendse, the intension is to update the background on each major. Like it changed on minors in the v7 timeperiod.

I think that's great, although I can imagine not everyone will like the updated, colourful background (as it can be a bit distracting from the login panel). Since we still ship the previous, more generic/muted background, they can easily set Umbraco:CMS:Content:LoginBackgroundImage to assets/img/login.jpg and revert back to that one👍🏻

Shouldn't we also change the installer background by changing the following to the new login.svg?

background: url('../img/installer.svg') no-repeat center center fixed;

We can then also remove the installer.svg file (since that's hardcoded into the CSS and most likely not referenced anywhere else) and possibly rename login.svg to a more generic background.svg?

@bergmania
Copy link
Copy Markdown
Member

The installer background is fairly new and we do not plan to change that for each version.

And as you say, people can easily change the background image, like before. I always changed the login background to the installer background in v10. Not everyone liked the v8-v10 login background either.

nikolajlauridsen added a commit that referenced this pull request Dec 1, 2022
* update marketplace url to its final, live url

* Added various Block Grid translations (EN & NL) (#13488)

* Added various translations

* Added another translation

* Change request

* Revert breaking changes adding IContextCache to deploy connectors (#13489)

* Remove breaking changes in Deploy connector interfaces

* Add extension methods for calling the new interface methods in a backwards-compatible way

* Create and pack empty file to add TFM dependency (#13475)

* Change login image to new SVG. (#13493)

* Only add global usings when ImplicitUsings is enabled (#13491)

* bump to rc6

* V11: Allow changing logging directory from configuration (#13485)

* Allow changing logging directory from configuration

* Clean up

* Missing return statement

* Apply suggestions from code review

Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com>

* Update src/Umbraco.Core/Constants-SystemDirectories.cs

Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com>

Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com>

* Move login.svg file

* Make sure contexbar fits within the available space (#13467)

* Make sure contexbar fits within the available space

* Ensuring context bar moves above, no matter size of it.

* Fixing apperance of connection-fixers

* Info panes not loading prerequisites (#13486)

* load relations immediately on init and remove call to non-existing function `appTabChange` on destroy

* load relations immediately on init and remove now not-used eventsService

* do not set layout gaps (#13496)

* Nuget updates (#13478)

* Updated nuget packages

* Remove npoco update

Co-authored-by: nikolajlauridsen <nikolajlauridsen@protonmail.ch>

* Nuget updates (#13478)

* Updated nuget packages

* Remove npoco update

Co-authored-by: nikolajlauridsen <nikolajlauridsen@protonmail.ch>

* Bump version to final

* V11/cherry pick flaky test (#13506)

* V10/feature/fixing flaky acceptance test (#13473)

* Bumped version

* Handle external authentication providers (#13487)

Co-authored-by: Jacob Overgaard <752371+iOvergaard@users.noreply.github.com>
Co-authored-by: Corné Hoskam <choskam@hotmail.com>
Co-authored-by: Ronald Barendse <ronald@barend.se>
Co-authored-by: Niels Lyngsø <nsl@umbraco.dk>
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com>
Co-authored-by: nikolajlauridsen <nikolajlauridsen@protonmail.ch>
Co-authored-by: Andreas Zerbst <73799582+andr317c@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants