Merra2 aerosol and climatological IN/CCN for microphysics (MG3)#381
Conversation
…sics into MG3_v1 updated from NCAR branch
AnningCheng-NOAA
requested review from
JulieSchramm,
climbfuji,
grantfirl and
llpcarson
as code owners
Update MG3_v1 PR
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
I am not familiar enough with the science to review the large amount of code changes in physics/radiation_aerosols.f. From a CCPP side of things, I deferred questions about doxygen changes in physics/radiation_aerosols.f to @mzhangw and @JulieSchramm. The changes to the other files are quite straightforward and good.
| !> The initialization program is to set up necessary parameters and | ||
| !! working arrays. | ||
| !! | ||
| !>\param NLAY number of model vertical layers (not used) | ||
| !>\param me print message control flag | ||
| !>\section aer_init_gen_al aer_init General Algorithm | ||
| !>\section gen_al General Algorithm |
There was a problem hiding this comment.
I am not a doxygen expert, and I would like to let @mzhangw and @JulieSchramm look at this change and the other doxygen changes for the scientific documentation in this file.
There was a problem hiding this comment.
@mzhangw looked at the doxygen changes and is happy with them.
| @@ -1336,56 +1143,56 @@ subroutine set_aercoef | |||
| endif | |||
|
|
|||
| !> - ending wave num for 61 aerosol spectral bands | |||
| read(NIAERCM,21) cline | |||
| read(NIAERCM,21) cline | |||
There was a problem hiding this comment.
There are several places in this file where trailing whitespaces are added. In case you need to make changes for doxygen anyway, let's remove them as well. If you don't need to make changes based on the review by our doxygen experts, then don't worry and we will fix them another time.
|
The Doxygen makeup looks good to me.
…On Mon, Mar 30, 2020 at 4:17 PM Dom Heinzeller ***@***.***> wrote:
***@***.**** commented on this pull request.
I am not familiar enough with the science to review the large amount of
code changes in physics/radiation_aerosols.f. From a CCPP side of things, I
deferred questions about doxygen changes in physics/radiation_aerosols.f to
@mzhangw <https://github.com/mzhangw> and @JulieSchramm
<https://github.com/JulieSchramm>. The changes to the other files are
quite straightforward and good.
------------------------------
In physics/radiation_aerosols.f
<#381 (comment)>:
> !> The initialization program is to set up necessary parameters and
!! working arrays.
!!
!>\param NLAY number of model vertical layers (not used)
!>\param me print message control flag
-!>\section aer_init_gen_al aer_init General Algorithm
+!>\section gen_al General Algorithm
I am not a doxygen expert, and I would like to let @mzhangw
<https://github.com/mzhangw> and @JulieSchramm
<https://github.com/JulieSchramm> look at this change and the other
doxygen changes for the scientific documentation in this file.
------------------------------
In physics/radiation_aerosols.f
<#381 (comment)>:
> @@ -1336,56 +1143,56 @@ subroutine set_aercoef
endif
!> - ending wave num for 61 aerosol spectral bands
- read(NIAERCM,21) cline
+ read(NIAERCM,21) cline
There are several places in this file where trailing whitespaces are
added. In case you need to make changes for doxygen anyway, let's remove
them as well. If you don't need to make changes based on the review by our
doxygen experts, then don't worry and we will fix them another time.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#381 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG7TW2SEEAFJ472DOYT5PKDRKEK53ANCNFSM4KJV2J7A>
.
|
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Approved - there are two follow-up changes that I am going to make when merging this into NCAR dtc/develop so that it comes back to master right away with the next commit (please do not make any of these changes, since it would require rerunning the tests):
- remove trailing whitespaces in
radiation_aerosols.f - in
aerinterp.f: do not stop the model when the netCDF aerosol input files are not found, instead assign a meaningful error message to CCPP'serrmsgand return with anerrflg > 0so that the host model (and not the physics) gets controls over how to stop the model properly.
@mzhangw @llpcarson @grantfirl @AnningCheng-NOAA @DusanJovic-NOAA @junwang-noaa
| fname=trim("aeroclim.m"//'01'//".nc") | ||
| inquire (file = fname, exist = file_exist) | ||
| if (.not. file_exist ) then | ||
| print *, 'fname not found, abort' |
There was a problem hiding this comment.
Comment for future cleanup (@climbfuji will do with the next commit): look into using the CCPP error handling mechanism to return with a properly set error message and error flag, do not abort the model'.
Please do not change this now, it would require rerunning all the tests.
| !> The initialization program is to set up necessary parameters and | ||
| !! working arrays. | ||
| !! | ||
| !>\param NLAY number of model vertical layers (not used) | ||
| !>\param me print message control flag | ||
| !>\section aer_init_gen_al aer_init General Algorithm | ||
| !>\section gen_al General Algorithm |
There was a problem hiding this comment.
@mzhangw looked at the doxygen changes and is happy with them.
3 participants
add the two options for IN/CCN activation and have total three options now: iccn=0 for temperature dependence, iccn=1 for climatological IN/CCN, and iccn=2 for MERRA2 aersol
add the option to enable RRTMg aerosol attenuation to be determined from prescribed MERRA2 climatology
add aerosol optical depth outputs for total, dust, black carbon, organic carbon, sulfate, and sea salt
add 4 regression tests completed in HERA and DELL: 1) SAS+GFDL with enabled RRTMg aerosol attenuation from prescribed MERRA2 climatology (fv3_gocart_clm in rt.conf_csaw), 2) CSAW+MG3 with with enabled RRTMg aerosol attenuation from prescribed MERRA2 climatology (fv3_gfsv16_csawmg in rt.conf_csaw), 3) CSAW+MG3 with enabled RRTMg aerosol attenuation from OPAC (fv3_gfsv16_csawmgt in rt.conf_csaw), and 4) CSAW+MG3 with climatological IN/CCN with enabled RRTMg aerosol attenuation from prescribed MERRA2 climatology (fv3_csawmg)
Associated PRs:
fv3atm #46
#381
ufs-weather-model #90