Skip to content

Fix macOS build errors; fv3atm: register diagnostics from stochastic physics only if allocated; ccpp-physics: cleanup CCPP cmake flags part 1#897

Merged
junwang-noaa merged 23 commits into
ufs-community:developfrom
climbfuji:cleanup-ccpp-test-gfdlmp-split-clw
Nov 12, 2021
Merged

Fix macOS build errors; fv3atm: register diagnostics from stochastic physics only if allocated; ccpp-physics: cleanup CCPP cmake flags part 1#897
junwang-noaa merged 23 commits into
ufs-community:developfrom
climbfuji:cleanup-ccpp-test-gfdlmp-split-clw

Conversation

@climbfuji
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji commented Nov 4, 2021

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Description

This PR updates the submodule pointers for fv3atm and ccpp-physics for the changes described in NOAA-EMC/ufsatm#417, NCAR/ccpp-physics#768 and NCAR/ccpp-physics#769:

Removing the special lowering of AVX2 flags to AVX-I for radiation_aerosols.f requires new baselines for all tests with the Intel compiler. Other changes do not affect the results (verified by testing the AVX2 --> AVX-I changes in isolation first, then adding the other changes on top). In particular, results do not change with the GNU compiler.

Issue(s) addressed

Fixes #309
Fixes #895

Testing

Full regression tests will be run on all tier-1 platforms when it is time to commit.

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3
  • opnReqTest for newly added/changed feature (for control test on hera.intel)
  • CI (28c4df3)

Dependencies

@climbfuji climbfuji marked this pull request as ready for review November 4, 2021 17:33
@climbfuji climbfuji changed the title fv3atm: register diagnostics from stochastic physics only if allocated; ccpp-physics: update convective transportable tracer handling for GFDL-MP Fix macOS build errors; fv3atm: register diagnostics from stochastic physics only if allocated; ccpp-physics: update convective transportable tracer handling for GFDL-MP Nov 4, 2021
@climbfuji climbfuji changed the title Fix macOS build errors; fv3atm: register diagnostics from stochastic physics only if allocated; ccpp-physics: update convective transportable tracer handling for GFDL-MP Fix macOS build errors; fv3atm: register diagnostics from stochastic physics only if allocated; ccpp-physics: cleanup CCPP cmake flags part 1 Nov 8, 2021
@climbfuji climbfuji added hera-gnu-BL Baseline Updates Current baselines will be updated. Waiting for Reviews The PR is waiting for reviews from associated component PR's. labels Nov 10, 2021
@github-actions github-actions Bot removed the run-ci label Nov 10, 2021
@climbfuji climbfuji requested a review from kgerheiser November 10, 2021 20:00
@climbfuji
Copy link
Copy Markdown
Collaborator Author

All regression tests, CI tests and OpnReqTests passed. Will merge ccpp-physics.

@climbfuji
Copy link
Copy Markdown
Collaborator Author

Ready to merge.

@junwang-noaa junwang-noaa merged commit 0cf6034 into ufs-community:develop Nov 12, 2021
zhanglikate pushed a commit to zhanglikate/ufs-weather-model that referenced this pull request Oct 20, 2025
* [production/RRFS.v1] To compile the model with new fms/2024.01 & RUC LSM deep soil temperature (ufs-community#852)

* Update the RUC LSM deep soil temperature from climatology to real foreast.

---------

Co-authored-by: haiqinli <38666296+haiqinli@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Baseline Updates Current baselines will be updated. Waiting for Reviews The PR is waiting for reviews from associated component PR's.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conditionally allocated variables skebu_wts, skebv_wts are always registered for diagnostic output Undefined symbols on macOS and Intel compiler

4 participants