Cleanup CCPP cmake flags part 1, remove extra logic that reduces optimization for radiation_aerosols.f, update CODEOWNERS, update README.md#773
Merged
Conversation
climbfuji
changed the title
climbfuji
changed the title
This was referenced Nov 8, 2021
climbfuji
changed the title
climbfuji
requested review from
DusanJovic-NOAA and
junwang-noaa
and removed request for
grantfirl
DusanJovic-NOAA
approved these changes
Nov 10, 2021
junwang-noaa
approved these changes
Nov 10, 2021
junwang-noaa
pushed a commit
to NOAA-EMC/ufsatm
that referenced
this pull request
Nov 12, 2021
…uplicate symbols error on macOS; ccpp-physics: cleanup CCPP cmake flags part 1; contains "fix the number of 2d fields nsfcprop2d" (#419) (#417) - Fixes a bug inGFS_diagnostics.F90 that registered several stochastic variables as diagnostic output even though th arrays are not allocated if the corresponding stochastic option is turned off - Fixes a problem that led to a "duplicate symbols" error on macOS with Intel by removing files from ccpp/CMakeLists.txt that get added automatically by CCPP - Updates the submodule pointer for ccpp-physics for the changes described in Cleanup CCPP cmake flags part 1, remove extra logic that reduces optimization for radiation_aerosols.f, update CODEOWNERS, update README.md NCAR/ccpp-physics#773 - Contains the changes in fix the number of 2d fields nsfcprop2d #419 from @HelinWei-NOAA - Updates the submodule pointer for GFDL_atmos_cubed_sphere to include latest JEDI control changes (contributed by @mark-a-potts)
junwang-noaa
pushed a commit
to ufs-community/ufs-weather-model
that referenced
this pull request
Nov 12, 2021
…physics only if allocated; ccpp-physics: cleanup CCPP cmake flags part 1 (#897) * Changes from CCPP/physics and fv3atm: - Fix duplicate symbols and undefined symbols errors on macOS - Register diagnostics from stochastic physics only if allocated in fv3atm -Updates the submodule pointer for ccpp-physics for the changes described in Cleanup CCPP cmake flags part 1, remove extra logic that reduces optimization for radiation_aerosols.f, update CODEOWNERS, update README.md NCAR/ccpp-physics#773 - Update top-level README.md in ccpp-physics * Set ECF_TRIES to 1 on WCOSS systems in ufs-weather-model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes unnecessary cmake compiler settings from ccpp-physics' top-level
CMakeLists.txt, updatesCODEOWNERSandREADME.md, and contains the changes frorm #771 (remove extra logic that reduces optimization for radiation_aerosols.f). While #771 changes the results for all tests, this PR does not (verified by creating a temporary baseline with the code in #771, and then verifying against it with the code in this PR).Associated PRs:
#773
NOAA-EMC/ufsatm#417
ufs-community/ufs-weather-model#897
For regression testing, see ufs-community/ufs-weather-model#897