WORK IN PROGRESS - Update convective transportable tracer handling for GFDL-MP#768
Closed
climbfuji wants to merge 6 commits into
Closed
WORK IN PROGRESS - Update convective transportable tracer handling for GFDL-MP#768climbfuji wants to merge 6 commits into
climbfuji wants to merge 6 commits into
Conversation
…like Zhao-Carr w.r.t. convective transportable tracers
…nup-ccpp-test-gfdlmp-split-clw
This was referenced Nov 4, 2021
climbfuji
requested review from
DeniseWorthen,
JongilHan66,
SMoorthi-emc,
ligiabernardet and
yangfanglin
panll
reviewed
Nov 18, 2021
Contributor
panll
left a comment
panll
left a comment
There was a problem hiding this comment.
This part looks good to me.
ligiabernardet
approved these changes
Nov 19, 2021
Collaborator
ligiabernardet
left a comment
ligiabernardet
left a comment
There was a problem hiding this comment.
I only reviewed the README file. Looks good, thanks for updating it. The only question I have it whether it is necessary to have the author and date of the last update. Typically this information can be provided by GutHub, without needing to be embedded in the file.
panll
approved these changes
Nov 19, 2021
JongilHan66
approved these changes
Nov 19, 2021
Contributor
JongilHan66
left a comment
JongilHan66
left a comment
There was a problem hiding this comment.
The changes look good.
…mes in physics/GFS_suite_interstitial.F90
…nup-ccpp-test-gfdlmp-split-clw
climbfuji
requested review from
SamuelTrahanNOAA and
mkavulich
as code owners
climbfuji
changed the title
Collaborator
Author
|
This PR is not necessary, based on the discussion in issue #769. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #769. See the issue for a comprehensive description of the problem and the solution implemented here.
The PR also updates the top-level
README.md, which is in dire need of being updated. (NOTE this may be included in another PR before this PR goes in)Associated PRs
n/a
Testing
See n/a