Skip to content

Update gsl/develop from develop 2021/03/31#69

Merged
DomHeinzeller merged 10 commits into
NOAA-GSL:gsl/developfrom
climbfuji:update_gsl_develop_from_develop_20210331
Apr 1, 2021
Merged

Update gsl/develop from develop 2021/03/31#69
DomHeinzeller merged 10 commits into
NOAA-GSL:gsl/developfrom
climbfuji:update_gsl_develop_from_develop_20210331

Conversation

@climbfuji
Copy link
Copy Markdown

@climbfuji climbfuji commented Mar 31, 2021

Description

This PR updates the gsl/develop from the authoritative repositories. There are no significant physics changes except the Thompson MP updates that were made first in gsl/develop and are thus already in our codebase.

Changes:

  • Final step to remove IPD (remove _ccpp labels from regression tests)
  • Stochastic physics updates for microphysics (not used by default) and for MOM6
  • Add -DAPP=<app_name> cmake option. Add timing info to rt logs
  • Upgrade coarse resolution OPAC aerosol with higher resolution MERRA2 data
  • Update dycore to the GFDL dev/emc (the FV3 202101 version)
  • Speed up recompiling code (ccpp-framework changes)
  • Minor CCPP framework/physics updates, minor regression test updates

Note that the MAKEOPT string (used by compile.sh, build.sh etc.) now requires one additional argument, namely the name of the app to build. For the uncoupled atmospheric model, the option is APP=ATM. Please see tests/rt*.conf for further examples.

Testing

No testing required, will merge immediately. The code is 100% identical to the current code in the authoritative repositories, except the .gitmodules and CODEOWNERS files that need to be different for our branches and for the code review process.

The last commit that was made to the authoritative repositories tested not only the usual regression tests, but also "our" tests in rt_ccpp_dev.conf (see ufs-community#498).

Screen Shot 2021-03-31 at 4 56 36 PM

Dependencies

NOAA-GSL/stochastic_physics#4
NOAA-GSL/ccpp-framework#13
NOAA-GSL/ccpp-physics#83
NOAA-GSL/fv3atm#79
#69

climbfuji and others added 8 commits March 17, 2021 23:10
… RAS updates and regression tests (ufs-community#448)

* Remove _ccpp labels from regression tests
* Replace rasmgshoc test with GFSv15p2+ras test, add debug test, add to rt.conf and rt_gnu.conf
* Rename regression tests in tests/rt_gnu.conf
* Replace v15p2+RAS regression tests with GFSv16+RAS tests
* Update regression test config files: change GFSv15p2+RAS to GFsv16+RAS
* Update regression test baseline date tag in tests/rt.sh
* Bugfixes in tests/tests/fv3_regional_quilt and tests/tests/fv3_regional_quilt_hafs
* Add REPRO=Y to compile line for multigases test
* Regression test logs for cheyenne, hera, gaea, jet
* Revert change to .gitmodules and update submodule pointer for fv3atm; run-ci
Addition of stochastic physics restarts in netCDF format that will be written at the restart interval, and at end of run.
Addition of stochastic cloud perturbation and microphysics perturbations for SPPT.
Clean up of stochastic physics code.

Co-authored-by: mlee03 <Mikyung.Lee@noaa.gov>
Co-authored-by: MinsukJi-NOAA <minsuk.ji@noaa.gov>
Co-authored-by: Brian Curtis <brian.curtis@noaa.gov>
…ommunity#477)

* Add -DAPP=<app_name> cmake option
* Add timestamps to all rt jobs
* Add compile time logs
* Remove fv3_msub.IN
* Support xsede/stampede machine

Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Co-authored-by: MinsukJi-NOAA <minsuk.ji@noaa.gov>
…tion MERRA2 aerosol data (ufs-community#451)


* Implement 0.625 degree MERRA2 climatological aerosol
* Update gfs_v16 tests
…unity#481)

Use the GFDL dycore repository dev/emc.
The GFDL dev/emc branch of dycore was synchronized with the GFDL master, which included the FV3 202101 upgrade except inline GFDL_MP:
https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere/releases/tag/FV3-202101-public
…sion test script updates (ufs-community#498)

- Updates to auto-rt in PR ufs-community#491 from @BrianCurtis-NOAA 
- Fixes to the regression testing scripts in branch https://github.com/DusanJovic-NOAA/ufs-weather-model/tree/rt_log_dir_fix from @DusanJovic-NOAA 
- Change baseline location on gaea to where emc.nemspara can write
- Update of submodule pointers for fv3atm, ccpp-framework and ccpp-physics, and new Thompson MP lookup tables for the changes described in the associated PRs below
- Remove tests fv3_gfs_v15p2_RRTMGP and fv3_gfs_v15p2_RRTMGP_debug from `tests/rt_gnu.conf` (same errors as with other GFS v15p2 tests previously, `compute_qs: saturation vapor pressure table overflow`)
@DomHeinzeller DomHeinzeller self-requested a review April 1, 2021 02:18
Copy link
Copy Markdown

@DomHeinzeller DomHeinzeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is 100% identical to the authoritative repositories (re-checked after updating the submodule pointers for fv3atm and stochastic) except .gitmodules as required for our branches. The latest ufs-weather-model commit for the authoritative repositories also tested rt_ccpp_dev.conf successfully, see the description of this PR.

@DomHeinzeller DomHeinzeller merged commit 1b8641c into NOAA-GSL:gsl/develop Apr 1, 2021
@DomHeinzeller
Copy link
Copy Markdown

@jkhender @tanyasmirnova @joeolson42 @hannahcbarnes @SamuelTrahanNOAA @shansun6 @haiqinli FYI - I updated gsl/develop from the authoritative repositories. Since I could use a graphical diff tool before and after each merge of the submodules and of the main repository, knowing that the code must be 100% identical except for CODEOWNERS and .gitmodules, I didn't ask you for reviews. I re-checked after the final merge of this PR and the code is still the same.

Please see the description above for important information on what changed in this PR, in particular the additional argument to the MAKEOPT string (and also that there were no significant physics changes except for those that originally came from gsl/develop, namely the Thompson MP updates).

@SamuelTrahanNOAA if you want to run regression tests for your WRF noise parameter code changes, they should pass against the official baselines for both Intel (using rt.conf) and gnu (using rt_gnu.conf). You can also use the head of gsl/develop to create your temporary baselines using rt_ccpp_dev.conf and then verify against it with your branch. It would be good if your PR activated this diagnostic output for one of the regression tests in rt_ccpp_dev.conf, for example.

Please let me know if you have questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants