release/public-v1: bug fix for threading issue in stochastic physics#55
Merged
junwang-noaa merged 5 commits intoFeb 11, 2020
Conversation
This was referenced Feb 10, 2020
DusanJovic-NOAA
approved these changes
Feb 10, 2020
Collaborator
Author
|
Regression tests passed on Cheyenne using both GNU and Intel. Hera is now in maintenance it seems, I cannot log in and check the results of the tests (kicked them off last night). |
Collaborator
Author
|
I think we can start merging the fv3atm PR, and wait with the final ufs-weather-model PR until hera comes back and I can get the logs. |
junwang-noaa
approved these changes
Feb 11, 2020
Collaborator
Author
|
Ok, this PR didn't have the regression test logs from hera.intel before it was merged. I am attaching them here, all tests pass. rt_hera_intel.log Please let me know if you want me to make a quick follow-up PR to commit |
Collaborator
|
Sorry for missing that. Please make a follow-up PR. Thanks
Jun
…On Tue, Feb 11, 2020 at 11:09 AM Dom Heinzeller ***@***.***> wrote:
Ok, this PR didn't have the regression test logs from hera.intel before it
was merged. I am attaching them here, all tests pass.
rt_hera_intel.log
<https://github.com/ufs-community/ufs-weather-model/files/4186707/rt_hera_intel.log>
Compile_hera.intel.log
<https://github.com/ufs-community/ufs-weather-model/files/4186708/Compile_hera.intel.log>
RegressionTests_hera.intel.log
<https://github.com/ufs-community/ufs-weather-model/files/4186710/RegressionTests_hera.intel.log>
Please let me know if you want me to make a quick follow-up PR to commit
Compile_hera.intel.log and RegressionTests_hera.intel.log. Thanks
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#55?email_source=notifications&email_token=AI7D6TMGJPTYM3PKOWTU7LTRCLES5A5CNFSM4KSWLGV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELNAACA#issuecomment-584712200>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TIITUJM5UCKEP4XYOTRCLES5ANCNFSM4KSWLGVQ>
.
|
Collaborator
Author
|
See here: #57 |
Collaborator
|
Committed, thanks.
…On Tue, Feb 11, 2020 at 11:15 AM Dom Heinzeller ***@***.***> wrote:
See here: #57 <#57>
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#55?email_source=notifications&email_token=AI7D6TP42QJCETT3U4QRTODRCLFJBA5CNFSM4KSWLGV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELNAXHY#issuecomment-584715167>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TKULBWGRFJBOGBYJ7LRCLFJBANCNFSM4KSWLGVQ>
.
|
climbfuji
added a commit
to climbfuji/ufs-weather-model
that referenced
this pull request
Jun 29, 2020
…rrfs_tests Jet build config updates (contains ufs-community#53 update the descriptions of the GSD_SAR_v1 and RRFS_v0 tests)
climbfuji
added a commit
to climbfuji/ufs-weather-model
that referenced
this pull request
Dec 30, 2020
…fs-community#55) Code is identical to original/current code in the authoritative repository (NOAA-PSD, branch master)
14 tasks
LarissaReames
pushed a commit
to LarissaReames/ufs-weather-model
that referenced
this pull request
Oct 22, 2021
…all that caused a reproducibility issue. (ufs-community#55) Co-authored-by: Chan-hoo.Jeon <chan-hoo.jeon@noaa.gov>
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR only updates the submodule pointers (and .gitmodules for the code review). For a description, see NOAA-EMC/ufsatm#62.