Fix SW net to ocean#1773
Merged
Merged
Conversation
on-behalf-of @ufs-community <jong.kim@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
update cmeps build to implement check4nans feature using module stored in cdeps repo
junwang-noaa
previously approved these changes
Aug 24, 2023
Collaborator
|
Jenkins ci logs are attached, apologies for the delay Jenkins had to be rerun on this PR due an issue with staging the test data, should be resolved now. |
BrianCurtis-NOAA
approved these changes
Aug 25, 2023
zach1221
approved these changes
Aug 25, 2023
jiandewang
suggested changes
Aug 25, 2023
Collaborator
jiandewang
left a comment
There was a problem hiding this comment.
approve based on previous 8 mini testing results and today's RT test
junwang-noaa
approved these changes
Aug 25, 2023
34 tasks
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements the ocean albedo calculation in CMEPS to determine SWnet sent to ocean.
A configuration variable (
ocean_albedo_limit) is added to the mediator attributes and set = 0.06 in order to match the behaviour of FV3 (see ccpp/physics/physics/GFS_surface_generic_post.F90).Two additional configuration variables (
flux_albav = true,albdir = 0.06) can be used to mimic the current treatement of SW net to the ocean even with the use of the mediator ocean albedo calculation.Top of commit queue on: TBD
Input data additions/changes
Anticipated changes to regression tests:
RegressionTests_hera.log
All global DATM and Coupled RTs will need new baselines. HAFS baselines do not change since the HAFS application uses SWnet from the ATM. The
atmwav_control_noaero_p8_intelreproduces all files except for the WAV restart file.Failed tests
Subcomponents involved:
Combined with PR's (If Applicable):
Commit Queue Checklist:
Linked PR's and Issues:
Testing Day Checklist:
Testing Log (for CM's):