Skip to content

Update CDEPS tests with GEFS forcing#1776

Merged
jkbk2004 merged 15 commits into
ufs-community:developfrom
binli2337:feature/update_cdeps
Jun 23, 2023
Merged

Update CDEPS tests with GEFS forcing#1776
jkbk2004 merged 15 commits into
ufs-community:developfrom
binli2337:feature/update_cdeps

Conversation

@binli2337
Copy link
Copy Markdown
Contributor

@binli2337 binli2337 commented Jun 1, 2023

Description

The shortwave radiation fields in the GEFS forcing file show that the maximum incoming shortwave radiation fields do not occur at local noon but at 18:00 local time. The stream_offset parameter in the datm.streams file will be used to make the 6-hour time shift.

Input data additions/changes

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
    datm_cdeps_control_gefs
    datm_cdeps_iau_gefs
    datm_cdeps_stochy_gefs
    datm_cdeps_bulk_gefs
    datm_cdeps_mx025_gefs

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved in section below
  • Confirm reviews completed in ALL sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne AND attach log to a PR comment.
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Hera
    • Orion
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment
      RegressionTests_hera

@DeniseWorthen DeniseWorthen mentioned this pull request Jun 2, 2023
37 tasks
@DeniseWorthen
Copy link
Copy Markdown
Collaborator

@binli2337 Unless you are using these settings, would you consider setting these both to 0 ? The verbosity especially makes the PET logs unreadable.

Verbosity = 5
dbug_flag = 5

@binli2337
Copy link
Copy Markdown
Contributor Author

@DeniseWorthen The nems.configure.datm_cdeps.IN file has been updated.

@binli2337
Copy link
Copy Markdown
Contributor Author

RegressionTests_hera.txt

@BrianCurtis-NOAA BrianCurtis-NOAA added Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. labels Jun 20, 2023
@FernandoAndrade-NOAA FernandoAndrade-NOAA self-assigned this Jun 20, 2023
@FernandoAndrade-NOAA
Copy link
Copy Markdown
Collaborator

@binli2337 Just a note that we'll start working on this PR after #1769 is complete and merged in, we're waiting on some final RT results before getting started with the merging process.

@FernandoAndrade-NOAA
Copy link
Copy Markdown
Collaborator

FernandoAndrade-NOAA commented Jun 20, 2023

#1769 was merged in, please go ahead and sync with develop. Thank you
@binli2337

@FernandoAndrade-NOAA FernandoAndrade-NOAA added the jenkins-ci Jenkins CI: ORT build/test on docker container label Jun 21, 2023
@FernandoAndrade-NOAA
Copy link
Copy Markdown
Collaborator

@BrianCurtis-NOAA Just a heads up, getting started with jenkins ci testing for this PR

@FernandoAndrade-NOAA
Copy link
Copy Markdown
Collaborator

FernandoAndrade-NOAA commented Jun 21, 2023

jenkins ci has completed with cpld_control_nowave_noaero_p8 failing, verifying with a manual run on hera to see if it's a pipeline issue. Otherwise, other tests pass.

@FernandoAndrade-NOAA
Copy link
Copy Markdown
Collaborator

Attached jenkins ci log. cpld_control_nowave_noaero_p8 dbg fails due to the time limit. bit, dcp, rst, and std pass in the manual run on Hera @zach1221 fyi
ufs-weather-model » ort-docker-pipeline » PR-1776 #1 Console [Jenkins].txt

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

I've started the Acorn testing, WCOSS2 is unavailable today, so since the changing tests are skipped on WCOSS2, there is essentially no baseline change and skipping it shouldn't cause any issues.

@zach1221
Copy link
Copy Markdown
Collaborator

@FernandoAndrade-NOAA the dbg ORT timeout error is a known issue, where investigation is on-going I believe. You have to increase wall-clock to get it to pass. If that is the only failure I think you can move on to the regression testing.

@FernandoAndrade-NOAA FernandoAndrade-NOAA added hera-BL Run Hera baseline creation cheyenne-BL jet-BL Run Baseline and RT on Jet labels Jun 22, 2023
@epic-cicd-jenkins epic-cicd-jenkins removed cheyenne-BL jet-BL Run Baseline and RT on Jet labels Jun 22, 2023
@zach1221 zach1221 added cheyenne-BL and removed hera-BL Run Hera baseline creation labels Jun 22, 2023
@zach1221 zach1221 added jet-BL Run Baseline and RT on Jet and removed jet-BL Run Baseline and RT on Jet labels Jun 22, 2023
@epic-cicd-jenkins
Copy link
Copy Markdown
Collaborator

Automated RT Failure Notification
Machine: cheyenne
Job: BL
Repo location: /glade/scratch/epicufsrt/autort/jenkins/autort/pr/1374669447/20230622092211/ufs-weather-model
Please manually delete: /glade/scratch/epicufsrt/FV3_RT/rt_40276
/glade/scratch/epicufsrt/GMTB/ufs-weather-model/RT/NEMSfv3gfs/develop-20230621
Exists already. It should not yet. Please delete.
Please make changes and add the following label back: cheyenne-BL

@zach1221
Copy link
Copy Markdown
Collaborator

Automated RT Failure Notification
Machine: cheyenne
Job: BL
Repo location: /glade/scratch/epicufsrt/autort/jenkins/autort/pr/1374669447/20230622101838/ufs-weather-model
Please manually delete: /glade/scratch/epicufsrt/FV3_RT/rt_57905
Please make changes and add the following label back: cheyenne-BL

@zach1221
Copy link
Copy Markdown
Collaborator

Automated RT Failure Notification
Machine: jet
Job: BL
Repo location: /lfs4/HFIP/hfv3gfs/role.epic/autort/pr/1374669447/20230622161905/ufs-weather-model
Please manually delete: /lfs4/HFIP/hfv3gfs/role.epic/RT_RUNDIRS/role.epic/FV3_RT/rt_290380
/lfs4/HFIP/hfv3gfs/role.epic/RT/NEMSfv3gfs/develop-20230621
Exists already. It should not yet. Please delete.
Please make changes and add the following label back: jet-BL

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

What is the issue with Jet and Cheyenne jobs? Why is it finding a baseline already created?

@FernandoAndrade-NOAA
Copy link
Copy Markdown
Collaborator

Creating baseline manually on Jet in the meantime while we figure out what's going on with Cheyenne and Jet

@zach1221
Copy link
Copy Markdown
Collaborator

The first jobs failed part way through because they were started without a token I think, so I started them again but the baseline directories were already created. I'll get it taken care of.

@epic-cicd-jenkins
Copy link
Copy Markdown
Collaborator

Automated RT Failure Notification
Machine: cheyenne
Job: BL
Repo location: /glade/scratch/epicufsrt/autort/jenkins/autort/pr/1374669447/20230622105147/ufs-weather-model
Please manually delete: /glade/scratch/zshrader/FV3_RT/rt_38115
Baseline creation and move successful
[RT] Repo location: /glade/scratch/epicufsrt/autort/jenkins/autort/pr/1374669447/20230622105256/ufs-weather-model
Please make changes and add the following label back: cheyenne-BL

@zach1221
Copy link
Copy Markdown
Collaborator

Apologies for the delay. Testing is finished, we'll proceed now with final reviews.

@jkbk2004
Copy link
Copy Markdown
Collaborator

Ok! all tests are done. Please go ahead for approvals.

@jkbk2004 jkbk2004 merged commit d45ddd6 into ufs-community:develop Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Baseline Updates Current baselines will be updated. jenkins-ci Jenkins CI: ORT build/test on docker container Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

SW rad appears shifted in CDEPS gefs forcing

8 participants