Skip to content

implement ocean albedo calculation#92

Merged
DeniseWorthen merged 480 commits into
NOAA-EMC:emc/developfrom
DeniseWorthen:feature/fixsw
Aug 25, 2023
Merged

implement ocean albedo calculation#92
DeniseWorthen merged 480 commits into
NOAA-EMC:emc/developfrom
DeniseWorthen:feature/fixsw

Conversation

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

@DeniseWorthen DeniseWorthen commented Jun 14, 2023

Description of changes

Implements ocean albedo calculation for UFS.

Specific notes

CMEPS Issues Fixed #91

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)

This will change answers in UFS for all cpld and datm tests.

@DeniseWorthen DeniseWorthen marked this pull request as ready for review August 11, 2023 17:34
* this is required because of the code structure which calculates
unbanded swpen (not used in ufs)
Comment thread .github/workflows/srt.yml
Copy link
Copy Markdown
Collaborator

@uturuncoglu uturuncoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DeniseWorthen It looks good to me.

@FernandoAndrade-NOAA
Copy link
Copy Markdown

Testing on #1773 has completed successfully, please continue with the merge process for this PR.

@DeniseWorthen DeniseWorthen merged commit c24fb59 into NOAA-EMC:emc/develop Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement ocean albedo calculation for UFS