Update upp submodule to fix in-line post issues for RRFS and HAFS#1286
Update upp submodule to fix in-line post issues for RRFS and HAFS#1286WenMeng-NOAA wants to merge 5 commits into
Conversation
…hafs Solved conflicts.
…hafs solved conflicts.
|
@WenMeng-NOAA This PR will be combined with #1298 , I'd be happy to bring your changes into my PR or you can combine my PR into yours. Whichever you prefer, we are next in the queue and should be able to start shortly. |
@BrianCurtis-NOAA Please bring my PR to your PR. Thanks! |
|
@WenMeng-NOAA OK. First thing would be to bring this fork up to date with develop branch of ufs-weather-model, then I can merge into mine. |
@WenMeng-NOAA Wait. It's just a .gitmodules addition. Nevermind. I can just add it to mine. |
3 participants
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsibility to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
Provide a detailed description of what this PR does. What bug does it fix, or what feature does it add? Is a change of answers expected from this PR? Are any library updates included in this PR (modulefiles etc.)?
This PR is to update the upp submodule to fix in-line post issues for RRFS and HAFS:
Extreme ABSV in RRFS 3-km North America grid
In-consistent dx/dy in grid2 metadata with model output when HAFS domain crossing the prime meridian
The baselines for RRFS and HAFS will be changed.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs