Skip to content

Update upp submodule for fixing in-line post issues for RRFS and HAFS#558

Merged
BrianCurtis-NOAA merged 5 commits into
NOAA-EMC:developfrom
WenMeng-NOAA:upp_update_rrfs_hafs
Jul 15, 2022
Merged

Update upp submodule for fixing in-line post issues for RRFS and HAFS#558
BrianCurtis-NOAA merged 5 commits into
NOAA-EMC:developfrom
WenMeng-NOAA:upp_update_rrfs_hafs

Conversation

@WenMeng-NOAA
Copy link
Copy Markdown
Contributor

Description

This PR is to update the upp submodule to fix in-line post issues for RRFS and HAFS:

  • Extreme ABSV in RRFS 3-km North America grid

  • In-consistent dx/dy in grid2 metadata with model output when HAFS domain crossing the prime meridian

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

  • fixes ufs-weather-model #1285

Testing

How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Yes. The baseline for RRFS and HAFS will be changed due to the fixes.
Have the ufs-weather-model regression test been run? On what platform?

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
  • Please commit the regression test log files in your ufs-weather-model branch

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first? No

Comment thread io/post_fv3.F90
@jkbk2004
Copy link
Copy Markdown
Collaborator

@DusanJovic-NOAA @HuiyaChuang-NOAA Regression tests are done. we can start merging in this pr. can you leave any comments and move on for approval?

@jkbk2004
Copy link
Copy Markdown
Collaborator

@WenMeng-NOAA sounds like we can clean up change conversations. can you click the resolved button? so that we can move on.

@WenMeng-NOAA
Copy link
Copy Markdown
Contributor Author

@WenMeng-NOAA sounds like we can clean up change conversations. can you click the resolved button? so that we can move on.

Done. Thanks! @jkbk2004

@BrianCurtis-NOAA BrianCurtis-NOAA merged commit b9d61f2 into NOAA-EMC:develop Jul 15, 2022
@WenMeng-NOAA WenMeng-NOAA deleted the upp_update_rrfs_hafs branch March 30, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants