Update post and regional_workflow hashes, QOL improvements#167
Merged
JulieSchramm merged 5 commits intoAug 31, 2021
Merged
Conversation
…o proper hash once PR is merged
jwolff-ncar
reviewed
Aug 26, 2021
Collaborator
jwolff-ncar
left a comment
jwolff-ncar
left a comment
There was a problem hiding this comment.
Couple of questions on the regional_workflow fork/branch set in this PR.
Collaborator
Author
|
Ran a number of tests on Cheyenne. The following WE2E tests passed:
|
Collaborator
Author
|
Ran another set of tests on Hera, all succeeded that were expected to (there are known failures in the testing system right now due to data being shuffled around). The following WE2E tests passed:
On Jet, I was not able to run any tests, as the old testing data has all been moved. I did build the code successfully. |
mkavulich
requested review from
JeffBeck-NOAA,
JulieSchramm and
gsketefian
as code owners
Collaborator
|
@mkavulich Can you elaborate on what the BUILD_ALWAYS flag does? What is the undesired behavior that this fixes? Thanks. |
Collaborator
Author
|
@gsketefian The BUILD_ALWAYS flag ensures that when making changes to the source code in src/ and rebuilding, |
shoyokota
pushed a commit
to shoyokota/ufs-srweather-app
that referenced
this pull request
Jul 15, 2022
* Fix externals reference for GSI in Externals.cfg The ncdiag was removed from GSI and replaced by a submodule. This requires the GSI to be checked out with the ncdiag submodule, which requires addition of a separate Externals_gsi.cfg file to specify which GSI submodules are needed. * Add newline to last line of Externals_gsi.cfg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
EMC_post builds are currently failing on Hera due to an update to NCEPLIBS. While that is annoying, we also discovered that the App's EMC_post hash is from December 2020...way out of date! Updating to the latest hash fixes the build issue. In addition, regional_workflow must be updated and an additional PR must be applied (https://github.com/NOAA-EMC/regional_workflow/pull/581) in order to accommodate the new executable and filenames for the newer EMC_post hash.
In addition, some long-overdue quality-of-life improvements are added:
TESTS CONDUCTED:
Cheyenne
Hera
DEPENDENCIES: