Updating the behavior of cmake to rebuild using changes to source code; fix devbuild.sh#91
Merged
JulieSchramm merged 2 commits intoJan 27, 2021
Conversation
…e are seen by make when rebuilding
mkavulich
requested review from
JeffBeck-NOAA,
JulieSchramm and
gsketefian
as code owners
kgerheiser
approved these changes
Jan 22, 2021
JeffBeck-NOAA
approved these changes
Jan 27, 2021
christinaholtNOAA
pushed a commit
to christinaholtNOAA/ufs-srweather-app
that referenced
this pull request
Nov 1, 2021
natalie-perlin
pushed a commit
to natalie-perlin/ufs-srweather-app
that referenced
this pull request
Jun 2, 2024
…physics (ufs-community#91) * Update .gitmodules and submodule pointer for fv3atm for code review and testing * Regression test logs for hera.intel using rt.sh * Regression test logs for wcoss_dell_p3 using NEMSCompsetRun * Update submodule pointer for FV3 after renaming S2S suite suite_FV3_GFS_2017_coupled_satmedmf.xml to suite_FV3_GFS_2017_satmedmf_coupled.xml * Regression test logs for wcoss_dell_p3 using rt.sh; regression test logs for wcoss_cray using rt.sh and NEMSCompsetRun * Regression test logs for hera.intel using NEMSCompsetRun * Revert change to .gitmodules and update submodule pointer for fv3atm
natalie-perlin
pushed a commit
to natalie-perlin/ufs-srweather-app
that referenced
this pull request
Jun 2, 2024
…ng PR#1863) (#1844) * Changes to logging and initialization of the CLM Lake Model. * merge ccpp-physics ufs-community#91 (UFS-SRW v3.0.0 SciDoc updates) 1. Use ice thickness hice(i) to find the level in the lake where ice is zero. 2. Do not allow lake temperature to be below freezing point if there is no ice. 3. If there is no snow or ice, do not allow surface lake temperature to be below freezing point. These changes fixed the problem with large errors in the energy budget at the beginning of the cold-start run with lakes. 4. Added flag to turn on debug print statements in the CLM lake model. * explicitly turn of frac_ice for flake * t_grnd(i) should be t_grnd(c) ------------------------------------------------------------------- Co-authored-by: Samuel Trahan <samuel.trahan@noaa.gov> Co-authored-by: Grant Firl <grant.firl@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Currently cmake is configured in such a way that if changes are made to the source code managed by the ExternalProject_Add functionality (currently this is all external code: UFS_UTILS, ufs-weather-model, and EMC_post), these source code changes will not be recognized by cmake or make if you attempt to rebuild using an existing build directory. By including the
BUILD_ALWAYS TRUEoption in the calls to ExternalProject_Add, callingmakein a pre-existing build directory will traverse the source code looking for changes, and rebuild if any changes are found using the native functionality of GNU make.In addition, this PR fixes the devbuild.sh script for the new environment file naming conventions introduced in #89
TESTS CONDUCTED:
Tested the build using devbuild.sh on Cheyenne (gnu), Hera (intel), and Orion (intel). Also made various code changes and rebuilds behaved as expected, as opposed to the old behavior of ignoring source code changes. These test builds behaved as expected and hoped both with the devbuild.sh script and via the officially supported manual cmake method.
Also ran suite of release branch end-to-end tests (minus the 3km versions) in regional_workflow/tests/testlist.release_public_v1.txt on Cheyenne (GNU compilers) and Hera. All passed.
CONTRIBUTORS:
Thanks to @LarissaReames-NOAA for suggesting and testing the
BUILD_ALWAYS TRUEoption.