rrfs_ci: Fix for building on Hera.#66
Closed
christinaholtNOAA wants to merge 3 commits into
Closed
Conversation
EMC_post builds are currently failing on Hera due to an update to
NCEPLIBS. While that is annoying, we also discovered that the App's
EMC_post hash is from December 2020...way out of date! Updating to the
latest hash fixes the build issue. In addition, regional_workflow must
be updated and an additional PR must be applied
(NOAA-EMC/regional_workflow#581) in order to accommodate the new
executable and filenames for the newer EMC_post hash.
In addition, some long-overdue quality-of-life improvements are added:
Including the "BUILD_ALWAYS" flag in CMakelists.txt; this will cause
code to be properly rebuilt by cmake after making changes
Adding "module load rocoto" to the Hera workflow environment file.
Rocoto is not loaded by default and can be unloaded by the build
environment, so adding this here (as it already exists for Cheyenne and
Orion) makes sense.
TESTS CONDUCTED:
Cheyenne
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_2017_gfdlmp
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_2017_gfdlmp_regional
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GSD_SAR
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_HRRR
grid_RRFS_CONUS_25km_ics_GSMGFS_lbcs_GSMGFS_suite_GFS_2017_gfdlmp
grid_RRFS_CONUS_25km_ics_GSMGFS_lbcs_GSMGFS_suite_GFS_v15p2
grid_RRFS_CONUS_25km_ics_HRRR_lbcs_HRRR_suite_GSD_SAR
grid_RRFS_CONUS_25km_ics_HRRR_lbcs_HRRR_suite_HRRR
grid_RRFS_CONUS_25km_ics_HRRR_lbcs_HRRR_suite_RRFS_v1beta
grid_RRFS_CONUS_25km_ics_HRRR_lbcs_RAP_suite_GSD_SAR
grid_RRFS_CONUS_25km_ics_HRRR_lbcs_RAP_suite_GSD_v0
grid_RRFS_CONUS_25km_ics_HRRR_lbcs_RAP_suite_HRRR
grid_RRFS_CONUS_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1alpha
grid_RRFS_CONUS_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta
Hera
grid_CONUS_25km_GFDLgrid_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
grid_RRFS_AK_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
grid_RRFS_AK_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2
grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_2017_gfdlmp
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_2017_gfdlmp_regional
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GSD_SAR
grid_RRFS_NA_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GSD_v0
grid_RRFS_SUBCONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
DEPENDENCIES:
Modify post files names to match what is used in latest EMC_post
NOAA-EMC/regional_workflow#581
christinaholtNOAA
requested review from
christopherwharrop-noaa and
venitahagerty
christinaholtNOAA
changed the title
robgpita
approved these changes
Aug 31, 2021
christopherwharrop-noaa
approved these changes
Aug 31, 2021
venitahagerty
approved these changes
Aug 31, 2021
Collaborator
Author
|
Well...it seems that Mike's actual PR was merged in the mean time. Why don't I go ahead and close this one, and merge his actual committed PR? |
Collaborator
|
@christinaholtNOAA - Agree. That is a better path. |
|
Did the PR solve the build problem? I decided to build the repo just to see
if I could, and it failed. Though maybe I did it wrong.
git clone -b merge_upp_fix
https://github.com/christinaholtNOAA/ufs-srweather-app.git
ufs-srweather-app-uppfix
...
FAIL: intel executable file
/scratch2/BMC/zrtrr/vhagerty/ufs-srweather-app-uppfix/test/../bin_intel/bin/ncep_post
does NOT exist
Venita
…On Tue, Aug 31, 2021 at 2:03 PM Christopher Harrop ***@***.***> wrote:
@christinaholtNOAA <https://github.com/christinaholtNOAA> - Agree. That
is a better path.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#66 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJGI4XX5RJJT5UEA3QA5EN3T7UYRVANCNFSM5DED4AWA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
Venita Hagerty, PhD
Research Associate
CIRA at NOAA, GSL/AVID
2B152, x6098
|
Collaborator
Author
|
I'll close this one for now, and will check on the issue that @venitahagerty brought up. |
Ruifang-Li
pushed a commit
to Ruifang-Li/ufs-srweather-app
that referenced
this pull request
Sep 23, 2021
* Add external for python_graphics. * Updating to merge of PR NOAA-GSL#66
Jeff-Duda
pushed a commit
to Jeff-Duda/ufs-srweather-app
that referenced
this pull request
Aug 3, 2022
Add diagnostic tendencies for all tracers. Move all d*3dt variables into a 4D sparse array stored as `dtend(i,k,dtidx(tracer,process))` to reduce memory usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Update to the top of ufs-community develop and merge a pending PR #167 that should fix the build on Hera. I have not tested the merge directly. I'm relying on the developer's tests for the PR.
Since this is a merge with develop, please do not squash the merge of this PR.
TESTS CONDUCTED:
Only those done with the ufs-community repo as listed in the merge commit.