Bugfix/wave1dtest#195
Conversation
Feature/add comparisons (#4)
merge develop/ufs-s2s-model
MOM_input template for initial condition files
merge fv3atm/develop
This reverts commit 0c8cb0b.
merge to latest develop
Debug mode capablility (#15)
Add debug compilation flag specification at top level (#17)
update to current ufs-weather-app (#19)
nomerg2atm, new MOM6 dev/emc
This reverts commit 57236a6.
Update FV3, NEMS (#21)
Update2020 01 (#23)
Update NEMS,FV3,CICE (#28)
Add CCPP to UFS-S2S-model
Remove IPD tests and CCPP repro tests from the regression test system…
Feature/alt compsetrun (ufs-community#75)
|
Ready for review. A new baseline for this test has been created on all platforms with temporary name "new_RT-Baselines_1d_bmwav_ccpp_cmeps". Once this PR has been merged, I will rename the test baseline on all platforms. |
DeniseWorthen
requested review from
JessicaMeixner-NOAA,
binli2337 and
junwang-noaa
|
How do we want to go about merging this PR? I've merged the latest develop. I can run the RTs using the |
|
I think that will work. First run RT against new_RT-Baselines_1d_bmwav_ccpp_cmeps. If that reproduces, then copy to new baseline and run final RT. |
|
Just to be sure, when you say 'copy to new baseline': I'll only be replacing the values of the existing |
|
Yes, that is what I mean. Sp in the new baseline, all the other tests will
be copied from the current 0921 baseline, but the test
RT-Baselines_1d_bmwav_ccpp_cmeps was created from your branch in the PR.
…On Mon, Sep 28, 2020 at 1:44 PM Denise Worthen ***@***.***> wrote:
Just to be sure, when you say 'copy to new baseline': I'll only be
replacing the values of the existing RT-Baselines_1d_bmwav_ccpp_cmeps in
the 0921 baseline. Once I do that, I can run all the RTs against the entire
baseline.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#195 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TMTCGIUBKRWXDKGTWLSIDDPNANCNFSM4RXN2YRA>
.
|
|
OK, so we'll have a new 0928 baseline with the single test fixed. |
against correct baseline for 1d bmark wave test
|
All logs added. Ready for review and merge. |
JessicaMeixner-NOAA
left a comment
JessicaMeixner-NOAA
left a comment
There was a problem hiding this comment.
@DeniseWorthen the changes look good. Thank you so much for catching and fixing this bug!
* Use hpc-stack libraries in ufs-s2s-model (ufs-community#191) * Update .gitmodules and submodule pointer for fv3atm for PR ufs-community#157 (RRTMG cloud overlap method update) (ufs-community#193) * Bugfix/wave1dtest (ufs-community#195) * fix MOM6 input template used by the cpld_fv3_ccpp_384_mom6_cice_cmeps_ww3_1d_bmark_rt test * Remove PIO as part of S2S model build in CMEPS and use hpc-stack (ufs-community#199) * update CMEPS submodule pointer (ufs-community#205) * Merge with upstream and fix conflicts Co-authored-by: BinLi-NOAA <bin.li@noaa.gov> Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com> Co-authored-by: Denise Worthen <denise.worthen@noaa.gov> Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
4 participants
Description of changes
Sets correct MOM_input template for 1d bmark wave test
Specific notes
Issues Fixed (include github issue #):
Bug fix for issue #192
Are changes expected to change answers?
new baseline for this test will be generated and will replace existing test files in develop-20200921
Specific changes:
Testing performed:
Hashes used for testing:
Co-authored by: