Skip to content

Feature/alt compsetrun#75

Merged
DeniseWorthen merged 15 commits into
ufs-community:developfrom
MinsukJi-NOAA:feature/alt_compsetrun
May 1, 2020
Merged

Feature/alt compsetrun#75
DeniseWorthen merged 15 commits into
ufs-community:developfrom
MinsukJi-NOAA:feature/alt_compsetrun

Conversation

@MinsukJi-NOAA
Copy link
Copy Markdown
Collaborator

Issue #74

  • Regression tests using shell scripts (rt.sh and others) were implemented
  • 2 ipd prod & 12 ccpp prod cases were added and tested on Hera


FFLAGS_OPT = -O2 -debug minimal -fp-model source -qoverride-limits -qopt-prefetch=3
FFLAGS_REPRO = -O2 -debug minimal -fp-model consistent -qoverride-limits -g -traceback
FFLAGS_DEBUG = -g -O0 -check all -check noarg_temp_created -check nopointer -warn -warn noerrors -fp-stack-check -fstack-protector-all -fpe0 -debug -traceback -ftrapuv
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like at commit a59b6cf we lost the additional debug flag -link_mpi=dbg in the hera.intel configuration; that has now propagated forward to the orion configuration.

Since adding this back might cause the debug test to fail, I will create an issue for adding this setting back to both the hera.intel and orion.intel.

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

Just to confirm my understanding, you were able to pass all 14 CCPP PROD baselines on Hera using rt.sh, correct?

@MinsukJi-NOAA
Copy link
Copy Markdown
Collaborator Author

Just to confirm my understanding, you were able to pass all 14 CCPP PROD baselines on Hera using rt.sh, correct?

Yes. The results can be found in tests/RegressionTests_hera.intel.log.

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

Sorry, I should have been more clear. The baselines were created using the NEMSCompsetRun; you were able to pass all those baselines using rt.sh.

@MinsukJi-NOAA
Copy link
Copy Markdown
Collaborator Author

Sorry, I should have been more clear. The baselines were created using the NEMSCompsetRun; you were able to pass all those baselines using rt.sh.

Yes. Baselines were created using NEMSCompsetRun.

Actually 2 are IPD PROD cases. 12 CCPP PROD cases do not include Debug and Gfdlmprad_*

Copy link
Copy Markdown
Collaborator

@DeniseWorthen DeniseWorthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the rt.sh tests pass the NemsCompsetRun baselines, I think this good to go.

@MinsukJi-NOAA
Copy link
Copy Markdown
Collaborator Author

@DeniseWorthen, I need to update this branch to the latest develop, right? I will do that, run rt.sh again on Hera, and report the results.

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

Yes, I think that is my understanding. Then we will have a second commit on s2s for updating the components to their Orion ports.

@junwang-noaa
Copy link
Copy Markdown
Collaborator

junwang-noaa commented May 1, 2020 via email

@MinsukJi-NOAA
Copy link
Copy Markdown
Collaborator Author

@DeniseWorthen DeniseWorthen merged commit 63b1aab into ufs-community:develop May 1, 2020
DeniseWorthen added a commit to DeniseWorthen/ufs-s2s-model that referenced this pull request May 4, 2020
@MinsukJi-NOAA MinsukJi-NOAA deleted the feature/alt_compsetrun branch May 6, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants