Update .gitmodules and submodule pointer for fv3atm for PR #157 (RRTMG cloud overlap method update)#193
Merged
binli2337 merged 3 commits intoSep 28, 2020
Conversation
Collaborator
Author
|
@junwang-noaa Please see here for the s2s model PR corresponding to ufs-community/ufs-weather-model#184. |
Collaborator
|
Regression tests have been run on Hera, Orion and Dell 3. The log files are at /scratch1/NCEPDEV/nems/Bin.Li/S2S/test/ufs-s2s-model/tests. |
Collaborator
|
@climbfuji would you please commit the log files to your branch? |
Collaborator
Author
|
@binli2337 conducted regression tests on hera.intel, orion.intel, wcoss_dell_p3. All tests passed regression test logs updated in the PR. |
Collaborator
Author
|
Thanks, @binli2337 for running the tests. Once we merged fv3atm, I will update the submodule pointer here and make sure that the code is identical between my branch that you used for testing and the new head of fv3atm develop. |
binli2337
approved these changes
Sep 25, 2020
junwang-noaa
approved these changes
Sep 28, 2020
Collaborator
junwang-noaa
left a comment
junwang-noaa
left a comment
There was a problem hiding this comment.
Thanks to Bin who ran all the RT tests!
MinsukJi-NOAA
pushed a commit
to MinsukJi-NOAA/ufs-s2s-model
that referenced
this pull request
Oct 7, 2020
* Use hpc-stack libraries in ufs-s2s-model (ufs-community#191) * Update .gitmodules and submodule pointer for fv3atm for PR ufs-community#157 (RRTMG cloud overlap method update) (ufs-community#193) * Bugfix/wave1dtest (ufs-community#195) * fix MOM6 input template used by the cpld_fv3_ccpp_384_mom6_cice_cmeps_ww3_1d_bmark_rt test * Remove PIO as part of S2S model build in CMEPS and use hpc-stack (ufs-community#199) * update CMEPS submodule pointer (ufs-community#205) * Merge with upstream and fix conflicts Co-authored-by: BinLi-NOAA <bin.li@noaa.gov> Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com> Co-authored-by: Denise Worthen <denise.worthen@noaa.gov> Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
ShanSunNOAA
pushed a commit
to ShanSunNOAA/ufs-s2s-model
that referenced
this pull request
Oct 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Update
.gitmodulesand submodule pointer for fv3atm for code review and testing the changes described in NOAA-EMC/ufsatm#157 and NCAR/ccpp-physics#487.Specific notes
Are changes expected to change answers?
FV3/ccpp/suites/suite_FV3_RRFS_v1beta.xmlin one of your testsTesting performed: none. I need someone to help me testing these changes.
For the corresponding ufs-weather-model PR and all associated PRs, see ufs-community/ufs-weather-model#184.