fixed stratosphere warm bias and code optimization for MERRA2#79
Closed
AnningCheng-NOAA wants to merge 111 commits into
Closed
fixed stratosphere warm bias and code optimization for MERRA2#79AnningCheng-NOAA wants to merge 111 commits into
AnningCheng-NOAA wants to merge 111 commits into
Conversation
…ade radiation_aerosols.f ccpp compliant
…Provided as ccpp interstitials.
… Provided as ccpp interstitials.
…Provided as ccpp interstitials.
…vided as ccpp interstitials.
… as ccpp interstitials.
Update CODEOWNERS
UFS/dev PR#6
UFS-dev PR#42
UFS-dev PR#54
UFS-dev PR#49
UFS-dev PR#57
UFS-dev PR#56
AnningCheng-NOAA
requested review from
Qingfu-Liu,
RuiyuSun,
dustinswales,
grantfirl and
gthompsnWRF
as code owners
grantfirl
approved these changes
Jun 7, 2023
Collaborator
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
These changes look OK to me from a CCPP point of view.
Qingfu-Liu
approved these changes
Jun 7, 2023
dustinswales
approved these changes
Jun 8, 2023
| qs_mp(iCol,iLay) = tracer(iCol,iLay,i_cldsnow) / (1.-q_lay(iCol,iLay)) | ||
| ni_mp(iCol,iLay) = tracer(iCol,iLay,i_cldice_nc) / (1.-q_lay(iCol,iLay)) | ||
| if (ltaerosol) then | ||
| if (ltaerosol .or. mraerosol) then |
Collaborator
There was a problem hiding this comment.
This is fine, but probably not needed.
The RRTMGP-ThompsonMP coupling is in a state of disarray and needs to be updated with many changes that have occurred in RRTMG, but were not ported to RRTMGP. (It's on my list to do this at somepoint...)
36 tasks
39 tasks
drnimbusrain
pushed a commit
to noaa-oar-arl/ccpp-physics
that referenced
this pull request
Mar 28, 2024
sync with ufs/dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolved issue ufs-community/ufs-weather-model#1786