UFS-dev PR#64#1015
Merged
Merged
Conversation
Development of a new unified cumulus convection scheme
update CODEOWNERS to replace Chunxi with Qingfu
grantfirl
requested review from
ChunxiZhang-NOAA,
JongilHan66,
Qingfu-Liu,
dustinswales,
haiqinli,
hannahcbarnes,
lisa-bengtsson,
mzhangw and
tanyasmirnova
as code owners
grantfirl
removed request for
ChunxiZhang-NOAA,
JongilHan66,
haiqinli,
hannahcbarnes,
lisa-bengtsson,
mzhangw and
tanyasmirnova
Qingfu-Liu
approved these changes
May 5, 2023
dustinswales
approved these changes
May 9, 2023
Collaborator
tanyasmirnova
left a comment
tanyasmirnova
left a comment
There was a problem hiding this comment.
@grantfirl Grant, I think that the version of set_soilveg_ruc.F90 in this PR does not have the latest changes to laitbl that should be in Joe's PR.
Collaborator
Author
Yes, you're right. This branch is behind the ufs/dev branch by a few commits. The changes that you mention will go in here in the same order that it went in the ufs/dev branch, so in a couple of PRs. |
Collaborator
|
OK. Sounds good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identical to ufs-community#64