32-bit physics with FV3_RAP#923
Merged
Merged
Conversation
| &, kind_grid = 8 &! atmos_cubed_sphere requres kind_grid=8 | ||
| &, kind_REAL = 4 &! used in cmp_comm | ||
| &, kind_LOGICAL = 4 & | ||
| &, kind_INTEGER = 4 ! -,,- |
Contributor
There was a problem hiding this comment.
I would rewrite this big #ifndef / #else / #endif block as:
integer, parameter :: kind_io4 = 4, kind_io8 = 8 , kind_ior = 8 &
&, kind_evod = 8, kind_dbl_prec = 8 &
&, kind_sngl_prec = 4
# ifdef __PGI
&, kind_qdt_prec = 8 &
# else
&, kind_qdt_prec = 16 &
# endif
&, kind_LOGICAL = 4 &
&, kind_INTEGER = 4 ! -,,-
#ifdef SINGLE_PREC
integer, parameter :: kind_rad = kind_sngl_prec &
&, kind_phys = kind_sngl_prec &
&, kind_taum = kind_sngl_prec &
&, kind_grid = kind_dbl_prec &! atmos_cubed_sphere requres kind_grid=8
&, kind_REAL = kind_sngl_prec ! used in cmp_comm
#else
integer, parameter :: kind_rad = kind_dbl_prec &
&, kind_phys = kind_dbl_prec &
&, kind_taum = kind_dbl_prec &
&, kind_grid = kind_dbl_prec &! atmos_cubed_sphere requres kind_grid=8
&, kind_REAL = kind_dbl_prec ! used in cmp_comm
#endif
avoiding unnecessary (repeated) definition of kinds that are equal in both cases.
Contributor
Author
|
@DusanJovic-NOAA Please review this PR. It is identical, except that it will be merged Wednesday. |
Contributor
Author
|
This branch was mistakenly marked as merged because it was identical to my other branch that was in a PR. This pull request is not actually merged because it lacks bug fixes from Dusan to correct calls to w3nco. |
dustinswales
added a commit
to dustinswales/ccpp-physics
that referenced
this pull request
Aug 12, 2022
…ade radiation_aerosols.f ccpp compliant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #930 replaces this. This PR should not have been closed as merged because it wasn't merged. See #930 for further development and conversation.
This is an attempt to get 32-bit physics working with the FV3_RAP suite, based on work done by NRL on the Neptune model. Presently, it fails during initialization. I've reached the limits of my knowledge of FV3 initialization and need help from other developers to finish this. See the ufs-weather-model PR for a test case: ufs-community/ufs-weather-model#1215
Most of these changes are from #918