Bug fix explicit in-canopy diffusion of tracers.#371
Conversation
…cers. Remove hpbl/kpbl update due to explicit in-canopy diffusion.
iri01
requested review from
Qingfu-Liu,
dustinswales,
grantfirl,
mzhangw and
rhaesung
as code owners
|
@grantfirl We would kindly request a high priority review of this bug fix . We are targeting getting this fix into UWM for UFS-AQMv8 operations, which has plans to start retro runs in May. Thank you! |
| hpbl(i) = hpbl_can(i) | ||
| kpbl(i) = kpbl_can(i) | ||
| enddo | ||
| ! do i = 1, im |
There was a problem hiding this comment.
Is there a reason to keep the commented out code?
(GitHub history takes care of tracking this, and keeps the code lean)
There was a problem hiding this comment.
No reason, will remove. This will be a part of future PR with explicit in-canopy effect on meteorology.
There was a problem hiding this comment.
@dustinswales, I removed the commented lines, as agreed. Also, I had to correct a truncated line that showed up in the RT build.
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
Looks fine to me. I agree with @drnimbusrain about removing code instead of commenting it out.
Qingfu-Liu
left a comment
Qingfu-Liu
left a comment
There was a problem hiding this comment.
similar to reviewer's comments, the commented code should be removed
|
Testing completed successfully on ufs-community/ufs-weather-model#3186. This PR can be merged. |
7 participants
Description of Changes:
Remove hpbl/kpbl update due to explicit in-canopy diffusion, this ensures no meteorology effects due to explicit in-canopy diffusion, only due to integrated-canopy diffusion.
Use 10-m interpolated winds (instead of 1 hybrid model layer winds) for explicit in-canopy diffusion of tracers.
Removing hpbl update due to explicit in-canopy diffusion ensure no meteorological changes on the SRW-App AQM predictions of temperature, humidity, and winds in regions of contiguous canopies.
Using 10-interpolated winds in the initialization of the explicit canopy layers (instead of the 1 hydrid model layer winds) for the diffusion of tracers leads to further reductions in ozone biases and it's precursors in regions on contiguous canopies.
Tests Conducted:
Tests conducted on Gaea-C6 with the SRW-App AQM configuration/compilers. Tests conducted for GFS v16 and GFS v17_p8 physics.
Dependencies:
Upcoming PR