Skip to content

Bug fix explicit in-canopy diffusion of tracers. #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grantfirl merged 4 commits into from
Apr 21, 2026
Merged

Bug fix explicit in-canopy diffusion of tracers. #371

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a20ac3
Use 10-m intepolated winds in the explicit in-canopy diffusion of tra…
iri01 Apr 7, 2026
92cb522
Clean up commented out code. Correct a truncated source line.
iri01 Apr 9, 2026
e640fe2
Merge branch 'ufs-community:ufs/dev' into fix_canopy_vdf
iri01 Apr 16, 2026
737f9a3
Comment out the integrated-canopy meteorology effect. Keep the lines …
iri01 Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 45 additions & 28 deletions physics/PBL/SATMEDMF/canopy_driver.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ subroutine canopy_driver_run(im,km,ntrac,ntcw,ntrw,
& swh,hlw,xmu,garea,zvfun,sigmaf, ! in
& psk,rbsoil,zorl,u10m,v10m,t2m, q2m,fm,fh,
& tsea,heat,evap,stress,spd1,
& kpbl, ! inout: kpbl
& kpbl, ! in: kpbl
& pgr,
& prsi,del,prsl,prslk,phii,phil,delt,tte_edmf,
& dspheat, ! in
Expand Down Expand Up @@ -91,7 +91,7 @@ subroutine canopy_driver_run(im,km,ntrac,ntcw,ntrw,
integer, intent(in) :: tc_pbl
integer, intent(in) :: use_lpt
integer, intent(in) :: kinver(:)
integer, intent(inout) :: kpbl(:)
integer, intent(in) :: kpbl(:)
logical, intent(in) :: gen_tend,ldiag3d
!
real(kind=kind_phys), intent(in) :: grav,pi,rd,cp,rv,hvap,hfus,fv,
Expand Down Expand Up @@ -143,7 +143,7 @@ subroutine canopy_driver_run(im,km,ntrac,ntcw,ntrw,
real(kind=kind_phys), intent(in) ::
& dusfc(:), dvsfc(:),
& dtsfc(:), dqsfc(:)
real(kind=kind_phys), intent(inout) ::
real(kind=kind_phys), intent(in) ::
& hpbl(:) ! use resolved hpbl in non-canopy columns
real(kind=kind_phys), intent(inout) ::
& dkt(:,:), dku(:,:)
Expand Down Expand Up @@ -847,6 +847,10 @@ subroutine canopy_driver_run(im,km,ntrac,ntcw,ntrw,
enddo

! NB. Using 10-m interpolated values creates shear and gives very high TKE tendencies
u1_can (:,1:km) = u1_can3 (:,1:km)
v1_can (:,1:km) = v1_can3 (:,1:km)

ws1_can (:,1:km) = sqrt(u1_can(:,1:km)**2+v1_can(:,1:km)**2)

t1_can (:,1:km) = t1_can3 (:,1:km)

Expand Down Expand Up @@ -889,10 +893,10 @@ subroutine canopy_driver_run(im,km,ntrac,ntcw,ntrw,
q1_can (:,kc, ntke ) = q1(:,k, ntke ) ! ntke always on

! Above-canopy wind components set to hybrid model layers
u1_can (:,kc) = u1 (:,k)
v1_can (:,kc) = v1 (:,k)
! u1_can (:,kc) = u1 (:,k)
! v1_can (:,kc) = v1 (:,k)

ws1_can(:,kc) = sqrt(u1_can(:,kc)**2+v1_can(:,kc)**2)
! ws1_can(:,kc) = sqrt(u1_can(:,kc)**2+v1_can(:,kc)**2)

end do

Expand All @@ -903,10 +907,10 @@ subroutine canopy_driver_run(im,km,ntrac,ntcw,ntrw,
q1_can (:,kc, ntke ) = q1(:,1, ntke ) ! ntke always on

!Sub-canopy values of wind components set to 1hy model layer
u1_can (:,kc) = u1 (:,1)
v1_can (:,kc) = v1 (:,1)
! u1_can (:,kc) = u1 (:,1)
! v1_can (:,kc) = v1 (:,1)

ws1_can(:,kc) = sqrt(u1_can(:,kc)**2+v1_can(:,kc)**2)
! ws1_can(:,kc) = sqrt(u1_can(:,kc)**2+v1_can(:,kc)**2)
end do

!
Expand Down Expand Up @@ -943,7 +947,7 @@ subroutine canopy_driver_run(im,km,ntrac,ntcw,ntrw,
IF (FRT_MASK(i) <= 0.) THEN

! Non-canopy columns
! kpbl_can(i) = kpbl(i) ! kpbl zero before original sat call
kpbl_can(i) = kpbl(i) ! kpbl zero before original sat call
hpbl_can(i) = hpbl(i)

! Non-canopy columns
Expand Down Expand Up @@ -1227,8 +1231,8 @@ subroutine canopy_driver_run(im,km,ntrac,ntcw,ntrw,
end do ! k = 1, km-nkc

! Apply minimum value on chemical conc after "canopy_to_resolved"
q2_mod (:,:, ntoz:ntrac1 ) =
& max(q2_mod (:,:, ntoz:ntrac1), concmin) ! after "canopy_to_resolved"
q2_mod (:,:, ntchs-1:ntrac1 ) =
& max(q2_mod (:,:, ntchs-1:ntrac1), concmin) ! after "canopy_to_resolved"

! Apply minimum value on humidity qmin before doing canopy_transfer & update tendency
q2_mod(:,:, ntqv) = max(q2_mod(:,:, ntqv),qmin)
Expand Down Expand Up @@ -1525,17 +1529,28 @@ subroutine canopy_driver_run(im,km,ntrac,ntcw,ntrw,
! Update ONLY chemical tracers (n=8, ntrac1)
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

! All chemical tracers (n=9, ntrac1)
! ntqv=1-8 are cloud/rain and "sgs_tke"
! n=8 "no2" (ntchs=9) GFDL
! n=9 "no" GFDL
! n=10 "o3" GFDL
! All chemical tracers (n= ntchs-1 , ntche-1 (ntrac1)
! ntqv = 1-7 cloud/rain and "sgs_tke"
! sgs_tke = 8 N/A
!
! ntchs-1 = 8 "no2" GFS_v16 GFDL MP
! ntchs = 9 "no" GFS_v16 GFDL MP
! n = 10 "o3" GFS_v16 GFDL MP
! ...
! NTRAC1 = 196
! ---NO PBL TEND --------
! n=197 ntche
! n=198 ntke
! -----------------------
! ntche-1= 196 NTRAC1 GFS_v16 GFDL MP
! ntche = 197 "cld_amt" GFS_v16 GFDL MP
! ntke = 198 "tke" GFS_v16 GFDL MP
! ---------------------------------------
! ntqv = 1-9 cloud/rain
! sgs_tke = 10 "sgs_tke" N/A
!
! ntchs-1 = 10 "no2" GFS_v17p8
! ntchs = 11 "no" GFS_v17p8
! n = 12 "o3" GFS_v17p8
! ...
! ntche-1 = 198 NTRAC1 GFS_v17p8
! ntke = 199 "tke" GFS_v17p8
! ---------------------------------------
DO n = ntchs-1, ntche-1 ! 10, ntche-1 (same as NTRAC1)

! Update all model layers
Expand All @@ -1559,14 +1574,16 @@ subroutine canopy_driver_run(im,km,ntrac,ntcw,ntrw,
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!> ## Save PBL height for diagnostic purpose
!
if (do_canopy) then
! if (do_canopy) then

do i = 1, im
hpbl(i) = hpbl_can(i)
kpbl(i) = kpbl_can(i)
enddo
! do i = 1, im

@dustinswales dustinswales Apr 8, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to keep the commented out code?
(GitHub history takes care of tracking this, and keeps the code lean)

@iri01 iri01 Apr 8, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason, will remove. This will be a part of future PR with explicit in-canopy effect on meteorology.

@iri01 iri01 Apr 9, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dustinswales, I removed the commented lines, as agreed. Also, I had to correct a truncated line that showed up in the RT build.

! IF (FRT_MASK(i) > 0.) THEN
! hpbl(i) = hpbl_can(i)
! kpbl(i) = kpbl_can(i)
! ENDIF
! enddo

endif !do_canopy
! endif !do_canopy
!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

Expand Down
4 changes: 2 additions & 2 deletions physics/PBL/SATMEDMF/canopy_driver.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@
units = index
dimensions = (horizontal_loop_extent)
type = integer
intent = inout
intent = in
[pgr]
standard_name = surface_air_pressure
long_name = surface pressure
Expand Down Expand Up @@ -629,7 +629,7 @@
dimensions = (horizontal_loop_extent)
type = real
kind = kind_phys
intent = inout
intent = in
[tkeh]
standard_name = vertical_turbulent_kinetic_energy_at_interface
long_name = vertical turbulent kinetic energy at model layer interfaces
Expand Down