Skip to content

Bug Fix to Explicit In-Canopy Vertical Diffusion of Tracers#1091

Merged
DusanJovic-NOAA merged 9 commits into
NOAA-EMC:developfrom
noaa-oar-arl:fix_canopy_vdf
Apr 22, 2026
Merged

Bug Fix to Explicit In-Canopy Vertical Diffusion of Tracers#1091
DusanJovic-NOAA merged 9 commits into
NOAA-EMC:developfrom
noaa-oar-arl:fix_canopy_vdf

Conversation

@iri01

@iri01 iri01 commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Description

Remove hpbl/kpbl update due to explicit in-canopy diffusion. This ensures no changes on the SRW-App AQM predictions of temperature, humidity, and winds in regions of contiguous canopies due to explicit in-canopy diffusion. The integrated-canopy vertical diffusion meteorology effects remains as before.

Using 10-interpolated winds in the initialization of the explicit canopy layers (instead of the 1 hydrid model layer winds) for the diffusion of tracers. This leads to further reductions in ozone biases (and it's precursors) in regions on contiguous canopies.

Testing

Tests conducted on Gaea-C6 with the SRW-App AQM configuration/compilers. Tests conducted for GFS v16 and GFS v17_p8 physics.

Upcoming PR tests...

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
  • Please commit the regression test log files in your ufs-weather-model branch

Dependencies

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

@drnimbusrain

Copy link
Copy Markdown
Contributor

@BrianCurtis-NOAA @dustinswales We would kindly request a high priority review of this bug fix . We are targeting getting this fix into UWM for UFS-AQMv8 operations, which has plans to start retro runs in May. Dependent on ccpp PR ufs-community/ccpp-physics#371

Thank you!

@iri01

iri01 commented Apr 8, 2026

Copy link
Copy Markdown
Contributor Author

I'm running RT tests on ursa.. will upload RT info soon.

@gspetro-NOAA

Copy link
Copy Markdown
Collaborator

@iri01 @drnimbusrain The CCPP PR was merged. Please revert .gitmodules and update the CCPP physics hash to a57d1a6.

@gspetro-NOAA

Copy link
Copy Markdown
Collaborator

@iri01 @drnimbusrain Could you please update the ccpp-physics hash and revert .gitmodules? We need to wrap up ufs-community/ufs-weather-model#3186 today.

@drnimbusrain

drnimbusrain commented Apr 22, 2026 via email

Copy link
Copy Markdown
Contributor

@drnimbusrain

Copy link
Copy Markdown
Contributor

@iri01 @drnimbusrain Could you please update the ccpp-physics hash and revert .gitmodules? We need to wrap up ufs-community/ufs-weather-model#3186 today.

@gspetro-NOAA Sorry for the delay, the .gitmodules and ccpp/physics have been reverted. Thank you.

@BrianCurtis-NOAA BrianCurtis-NOAA left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new changes look good to me

@BrianCurtis-NOAA

Copy link
Copy Markdown
Collaborator

@DusanJovic-NOAA could you review and approve/merge when ready?

@DusanJovic-NOAA DusanJovic-NOAA merged commit 9c4df8d into NOAA-EMC:develop Apr 22, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants