Noahmp no stcslcadj at0inc#326
Merged
grantfirl merged 8 commits intoOct 29, 2025
Merged
Conversation
* ufs/dev: Remove non-warning log write statement fix typo make some Thompson parameters public move calculation of av_i make some Thompson tuning parameters externally accessible bugfix: initialize data so it is never NaN. See NCAR/ccpp-physics Issue 1155 for details add parameterized type for canopy_utils_mod function arguments Update physics/PBL/SATMEDMF/satmedmfvdifq.meta Update physics/PBL/SATMEDMF/satmedmfvdifq.F Update physics/PBL/SATMEDMF/satmedmfvdifq.F address reviewer's comments physics/Interstitials/UFS_SCM_NEPTUNE/GFS_time_vary_pre.scm.F90: check that w3emc is using the expected precision physics/Interstitials/UFS_SCM_NEPTUNE/GFS_time_vary_pre.fv3.F90: check that w3emc is using the expected precision Remove copy_error calls from one-thread region. Access errmsg and errflg directly. Remove unused label and unnecessary return statement. Change one more "can not" to cannot. Insert return calls if an error occurs, remove unnecessary return statements. More cleanup Remove return call from inside OpenMP region Insert return calls if an error occurs, remove unnecessary returns at the end of subroutines, remove duplicate print statements Insert return calls if an error occurs
…25_09_04 Sync from NCAR/main + Thompson params
tsga
requested review from
Qingfu-Liu,
barlage,
cenlinhe,
dustinswales,
grantfirl,
mzhangw and
rhaesung
as code owners
This was referenced Oct 17, 2025
barlage
approved these changes
Oct 23, 2025
grantfirl
approved these changes
Oct 27, 2025
rhaesung
approved these changes
Oct 27, 2025
|
Testing completed successfully on parent WM PR #2941. This PR can begin the merge process. |
This was referenced Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes:
After adding soil moisture (SLC) and temperature (STC) increments in ccpp-physics/Noahmp driver, adjustments are made to ensure consistency between liquid/frozen soil moisture and temperature. Currently this is applied even when all the increments are (intentionally) 0. We do not want to change the physics model predicted states when no/zero increments are added to STC and SLC.
The changes introduced in this PR check and skip the adjustment section if the magnitude of an increment is zero (below threshold).
Tests Conducted:
Tested by running a low-res (C384C192) global workflow case with Soil DA, and comparing it to previous outputs without the code changes here. The results outputs have the expected changes.
UFSWM RT tests are currently running.
Dependencies:
Related PR: NOAA-EMC/noahmp/pull/18 (NOAA-EMC/noahmp#18)
Issue (optional):
ufs-community/ccpp-physics/issues/323