Noahmp No STCSLC Adjustment for 0 increments#18
Merged
Conversation
CoryMartin-NOAA
approved these changes
Oct 15, 2025
This was referenced Oct 17, 2025
barlage
approved these changes
Oct 27, 2025
|
Testing completed successfully on parent WM PR #2941. This PR can begin the merge process. |
|
@uturuncoglu @barlage Is this something you can take care of? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After adding soil moisture (SLC) and temperature (STC) increments in Noahmp driver, adjustments are made to ensure consistency between liquid/frozen soil moisture and temperature. Currently this is applied even when all the increments are (intentionally) 0. We do not want to change the physics model predicted states when no/zero increments are added to STC and SLC
The changes introduced in this PR check and skip the adjustment section if the magnitude of an increment is zero (below threshold).
Tested by running a low-res (C384C192) global workflow case with Soil DA, and comparing it to previous outputs without the code changes here. The results outputs have the expected changes.
Related to
ufs-community/ccpp-physics#323
NOAA-EMC/ufsatm#1024
ufs-community/ufs-weather-model#2934