Combined updates from UFS-dev PR325 and PR326#633
Merged
Conversation
grantfirl
requested review from
dustinswales,
grantfirl,
mkavulich and
scrasmussen
as code owners
grantfirl
approved these changes
Nov 10, 2025
Collaborator
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
Approved pending input from Dom on the physics PR.
scrasmussen
approved these changes
Nov 10, 2025
Member
scrasmussen
left a comment
scrasmussen
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
Collaborator
|
@scrasmussen You may want to re-review this because I added some changes to GFS_typedefs to generalize the cloud fraction changes to be host controlled by request from NRL. |
Collaborator
|
FYI, RTs with the configurable code changes are slightly different than beforehand. I looked at the differences, and they are tiny (near precision level) and only with release compilation flags, so I'm pretty confident that this is optimization related. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR catches the NCAR:main branch up with changes from the ufs-community:ufs/dev branch.
Associated ufs/dev PR:
Associated ufsatm PR:
Associated NCAR PR:
TESTS CONDUCTED: SCM RTs
REGRESSION TEST CHANGES: