Skip to content

Update calculation of time-averaged radiation variables #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhaesung merged 77 commits into from
Oct 7, 2025
Merged

Update calculation of time-averaged radiation variables #262

Show file tree
Hide file tree
Changes from 76 commits
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
8c2afec
Moved fluxr computation from GFS_rrtmg_post to dcyc2t3 to provide cor…
LarissaReames Dec 16, 2024
739b174
Remove fluxr calculation from RRTMG post routine.
LarissaReames Dec 17, 2024
f20c5a4
Update documentation of dcyc2t3 to account for the variables moved fr…
LarissaReames Dec 17, 2024
9d251ba
Combined GFS_rrtmg/rrtmgp_post.F90 in to GFS_radiation_post.F90
LarissaReames Dec 19, 2024
b876e1e
Replaced 'rrtmg' in warning/error message with 'radiation' to avoid c…
LarissaReames Jan 10, 2025
e65b355
Merge branch 'ufs/dev' of https://github.com/ufs-community/ccpp-physi…
LarissaReames Jan 13, 2025
868dadb
update cloud/radiation/land
rhaesung Jan 3, 2025
ba78577
update radiation_clouds.f according to the review
rhaesung Jan 6, 2025
f3fe9ca
update module_sf_noahmp_glacier.F90 and module_sf_noahmplsm.F90 accor…
rhaesung Jan 21, 2025
1635966
update module_sf_noahmplsm.F90
rhaesung Jan 22, 2025
6619587
update module_sf_noahmplsm.F90
rhaesung Jan 22, 2025
3b2a01a
skip land component for first time step
uturuncoglu Nov 8, 2024
3110557
minor fix for restart
uturuncoglu Dec 6, 2024
48278a5
add simple land flux calculation that is used in the initial time step
uturuncoglu Dec 19, 2024
73e032e
fix minor issue
uturuncoglu Dec 19, 2024
08857a8
remove flag_init
uturuncoglu Dec 23, 2024
c25d36c
correction for flux calculation
uturuncoglu Dec 27, 2024
6b40c48
fix space issue
uturuncoglu Jan 7, 2025
5c3886a
add a new parameter to control if G-F cold starts or not
JiliDong-NOAA Aug 22, 2024
4c558e1
Update physics/Interstitials/UFS_SCM_NEPTUNE/GFS_phys_time_vary.fv3.*…
climbfuji Dec 19, 2024
428ebdb
Revert "Update physics/Interstitials/UFS_SCM_NEPTUNE/GFS_phys_time_va…
LarissaReames Feb 6, 2025
a5b7c0f
Revert "add a new parameter to control if G-F cold starts or not"
LarissaReames Feb 6, 2025
09c97a5
Revert "fix space issue"
LarissaReames Feb 6, 2025
00cf6e7
Revert "correction for flux calculation"
LarissaReames Feb 6, 2025
2811f8c
Revert "remove flag_init"
LarissaReames Feb 6, 2025
4d40d7e
Revert "fix minor issue"
LarissaReames Feb 6, 2025
db66342
Revert "add simple land flux calculation that is used in the initial …
LarissaReames Feb 6, 2025
770e193
Revert "minor fix for restart"
LarissaReames Feb 6, 2025
15161d9
Revert "skip land component for first time step"
LarissaReames Feb 6, 2025
f32a01e
Revert "update module_sf_noahmplsm.F90"
LarissaReames Feb 6, 2025
c37e2d2
Revert "update module_sf_noahmplsm.F90"
LarissaReames Feb 6, 2025
1a55e3b
Revert "update module_sf_noahmp_glacier.F90 and module_sf_noahmplsm.F…
LarissaReames Feb 6, 2025
75f72bb
Revert "update radiation_clouds.f according to the review"
LarissaReames Feb 6, 2025
8a96ec2
Revert "update cloud/radiation/land"
LarissaReames Feb 6, 2025
4f2a977
Merge branch 'ufs/dev' into feature/rad-fix
LarissaReames Feb 6, 2025
8c549ef
Merge branch 'ufs/dev' into feature/rad-fix
LarissaReames Feb 12, 2025
33df427
Merge branch 'ufs/dev' into feature/rad-fix
LarissaReames Feb 24, 2025
140b49e
Add radiation_tools.F90 to GFS_rrtmg_setup.meta to allow compiling of…
LarissaReames Feb 25, 2025
5064846
Updated comments and documentation to account for merger of rrtmg_ an…
LarissaReames Feb 25, 2025
2caf5ff
Merge branch 'feature/rad-fix' into feature/rad-fix_gjf
grantfirl Mar 21, 2025
cff691b
Merge branch 'ufs/dev' into feature/rad-fix_gjf
grantfirl Mar 28, 2025
4e5a6e9
Merge branch 'ufs/dev' into feature/rad-fix_gjf
grantfirl Apr 11, 2025
cf56256
Merge branch 'ufs/dev' into feature/rad-fix_gjf
grantfirl Jun 27, 2025
dd0b277
modifies href calcuation to href=max(Omax, 2*sigma, hpbl)
rhaesung May 22, 2025
5547073
update drag_suite.F90 based on Mike Toy's comment
rhaesung May 27, 2025
7db9333
Merge branch 'ufs/dev' of https://github.com/ufs-community/ccpp-physi…
dustinswales Jul 8, 2025
90cae2d
Merge pull request #1147 from scrasmussen/ufs-dev-PR287
grantfirl Jul 8, 2025
9ee6226
Some refactoring
dustinswales Jul 9, 2025
a146789
3D-TKE EMDF GFS PBL scheme related changes from FIU (Ping Zhu, Ping.Z…
BinLiu-NOAA May 9, 2025
7c5bf57
Add an option to use liquid potential temperature in temperature
BinLiu-NOAA Feb 4, 2025
599462c
Update sa3dtke variables standard names in SATMEDMF
Jun 3, 2025
977c3d7
Update nonlocal mixing and coding style for sa3dkte in ccpp physics
Jun 4, 2025
5f53264
Updates on SA3DTKE non-local transport
Jun 16, 2025
f8d2081
Update nonlocal mass-flux transport for Shear production of TKE
Jun 17, 2025
57dd80c
Merge branch 'combo_20250625' of https://github.com/grantfirl/ccpp-ph…
dustinswales Jul 14, 2025
9b527e4
Merge pull request #1148 from NCAR/ufs-dev-pr279
grantfirl Jul 15, 2025
87610cf
Merge branch 'main' of https://github.com/NCAR/ccpp-physics into HEAD
dustinswales Jul 16, 2025
3f516fc
Reproducable results with control_c384
dustinswales Jul 18, 2025
bf679fb
Merge branch 'ufs/dev' into feature/rad-fix_gjf
grantfirl Aug 5, 2025
36920bc
Merge pull request #1149 from dustinswales/ufs-dev-PR295
grantfirl Aug 6, 2025
db52243
Merge branch 'feature/gfdlmpv3' into ufs-dev-PR195
grantfirl Aug 6, 2025
8bb67bc
Merge branch 'feature/aqm_canopy2' into ufs-dev-PR253
grantfirl Aug 8, 2025
5410686
Merge branch 'combo_265_291' into ufs-dev-PR302
grantfirl Aug 11, 2025
2f21a38
fix compilation errors in GFS_phys_time_vary.scm.F90
grantfirl Aug 11, 2025
998a2be
Merge commit '9ee6226' into feature/rad-fix_gjf
grantfirl Aug 12, 2025
5638297
Merge commit '3f516fc' into feature/rad-fix_gjf
grantfirl Aug 12, 2025
76cfbfe
Merge commit '2f21a38e' into feature/rad-fix_gjf
grantfirl Aug 12, 2025
1ed3326
revert doc changes from old releases
grantfirl Aug 12, 2025
32d5b9a
fix metadata dependencies to compile suites with RRTMG and RRTMGP sep…
grantfirl Aug 12, 2025
6710010
isolate RRTMG-only statements in GFS_radiation_post for debugging
grantfirl Aug 14, 2025
d7c25d7
add back in some optional RRTMGP diags
grantfirl Aug 14, 2025
eeb2e03
add back in some more optional RRTMGP diags
grantfirl Aug 15, 2025
66a3a88
add back remaining RRTMGP diagnostics
grantfirl Aug 15, 2025
56e66e6
Merge branch 'ufs/dev' into feature/rad-fix_gjf
grantfirl Aug 15, 2025
fcd0924
Merge branch 'ufs/dev' into feature/rad-fix_gjf
grantfirl Sep 18, 2025
60e5556
Merge branch 'ufs/dev' into feature/rad-fix_gjf
grantfirl Oct 2, 2025
31618fc
fix vertical dimension issue in GFS_radiation_post
grantfirl Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,11 +154,10 @@ physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rad_time_vary.fv3.*
physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rad_time_vary.scm.* @grantfirl @rhaesung @Qingfu-Liu @dustinswales
physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmgp_cloud_mp.* @dustinswales @Qingfu-Liu @grantfirl @rhaesung @Qingfu-Liu @dustinswales
physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmgp_cloud_overlap.* @dustinswales @Qingfu-Liu @grantfirl @rhaesung @Qingfu-Liu @dustinswales
physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmg_post.* @Qingfu-Liu @dustinswales @grantfirl @rhaesung @Qingfu-Liu @dustinswales
physics/Interstitials/UFS_SCM_NEPTUNE/GFS_radiation_post.* @Qingfu-Liu @dustinswales @grantfirl @rhaesung @Qingfu-Liu @dustinswales
physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmgp_pre.* @dustinswales @Qingfu-Liu @grantfirl @rhaesung @Qingfu-Liu @dustinswales
physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmg_pre.* @Qingfu-Liu @dustinswales @grantfirl @rhaesung @Qingfu-Liu @dustinswales
physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmgp_setup.* @dustinswales @Qingfu-Liu @grantfirl @rhaesung @Qingfu-Liu @dustinswales
physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmgp_post.* @dustinswales @Qingfu-Liu @grantfirl @rhaesung @Qingfu-Liu @dustinswales
physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmg_setup.* @Qingfu-Liu @dustinswales @grantfirl @rhaesung @Qingfu-Liu @dustinswales
physics/Interstitials/UFS_SCM_NEPTUNE/GFS_SCNV_generic_post.* @grantfirl @rhaesung @Qingfu-Liu @dustinswales
physics/Interstitials/UFS_SCM_NEPTUNE/GFS_SCNV_generic_pre.* @grantfirl @rhaesung @Qingfu-Liu @dustinswales
Expand Down
6 changes: 3 additions & 3 deletions physics/Interstitials/UFS_SCM_NEPTUNE/GFS_phys_time_vary.scm.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ subroutine GFS_phys_time_vary_init (
if(iaermdl==1) then
call read_aerdata (me,master,iflip,idate,errmsg,errflg)
elseif(iaermdl==6) then
call read_aerdata_dl (me,master,iflip,idate,errmsg,errflg)
call read_aerdata_dl (me,master,iflip,idate,fhour,errmsg,errflg)
end if
endif
if (errflg /= 0) return
Expand Down Expand Up @@ -816,13 +816,13 @@ subroutine GFS_phys_time_vary_timestep_init (
fhour, iflip, jindx1_aer, jindx2_aer, &
ddy_aer, iindx1_aer, &
iindx2_aer, ddx_aer, &
levs, prsl, aer_nm)
levs, prsl, aer_nm, errmsg, errflg)
elseif (iaermdl==6) then
call aerinterpol_dl (me, master, nthrds, im, idate, &
fhour, iflip, jindx1_aer, jindx2_aer, &
ddy_aer, iindx1_aer, &
iindx2_aer, ddx_aer, &
levs, prsl, aer_nm)
levs, prsl, aer_nm, errmsg, errflg)
endif
endif

Expand Down
473 changes: 473 additions & 0 deletions physics/Interstitials/UFS_SCM_NEPTUNE/GFS_radiation_post.F90
View file
Open in desktop

Large diffs are not rendered by default.

Loading