Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

Delay before filling completions #1099

Merged
merged 2 commits into from
Apr 13, 2021
Merged

Delay before filling completions #1099

merged 2 commits into from
Apr 13, 2021

Conversation

ueokande
Copy link
Owner

@ueokande ueokande commented Apr 12, 2021

Fix #158 and #1024

Insert a delay before filling completions. When trying opening a new tab or window using the open command, typing is impaired by the search as you type functionality, especially if you have a large search base, like long history or many bookmarks.

@ueokande ueokande marked this pull request as ready for review April 13, 2021 12:49
@ueokande ueokande merged commit 14df305 into master Apr 13, 2021
@ueokande ueokande deleted the delay-completion branch April 13, 2021 12:50
@@ -72,6 +85,19 @@ describe("background/usecases/filters", () => {
});

describe("filterByOrigin", () => {
it("remains items less than minimam length", () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimum?

@@ -54,6 +54,19 @@ describe("background/usecases/filters", () => {
});

describe("filterByPathname", () => {
it("remains items less than minimam length", () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimum?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

open / tab-open console gets slowing when query string is long
2 participants