Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

[tab]open not responsive while typing #1024

Closed
1 of 2 tasks
nucatus opened this issue Mar 10, 2021 · 4 comments
Closed
1 of 2 tasks

[tab]open not responsive while typing #1024

nucatus opened this issue Mar 10, 2021 · 4 comments
Milestone

Comments

@nucatus
Copy link

nucatus commented Mar 10, 2021

I'm opening this issue because:

  • I'll report a bug
  • I'll propose a new feature

Description

When trying opening a new tab or window using the open command, typing is impaired by the search as you type functionality, especially if you have a large search base, like long history or many bookmarks.

I'd recommend introducing a hysteresis when typing that will run a search only after a particular timeout after a key was pressed.

Failure Information (for bugs)

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. step 1
  2. step 2
  3. you get it...

System configuration

  • Operating system: OSX 11
  • Firefox version: 86.0
  • Vim-Vixen version: 0.32

Console logs

Any relevant log in developer tools:

@nucatus
Copy link
Author

nucatus commented Mar 10, 2021

I see this issue was already addressed in an old PR #502. Would it be possible to get this merged? This looks to solve the issue with using the console.

@wolfisberg
Copy link

Maybe this should be configurable. The PR hardcoded the delay to 150 ms, which would just make the console less responsive for people who don't suffer from this issue.

@nucatus
Copy link
Author

nucatus commented Mar 16, 2021

There definitely should be a hysteresis with every keystroke if search results can not be provided at a speed that wouldn't impair the typing experience.

Moreover, I don't understand why complete is a synchronous action, in the end?!

@ueokande ueokande added this to the 1.1.0 milestone Mar 28, 2021
@ueokande
Copy link
Owner

fixed in #1099

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants