Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

open / tab-open console gets slowing when query string is long #158

Closed
1 of 2 tasks
Biacco42 opened this issue Nov 15, 2017 · 8 comments · Fixed by #1099
Closed
1 of 2 tasks

open / tab-open console gets slowing when query string is long #158

Biacco42 opened this issue Nov 15, 2017 · 8 comments · Fixed by #1099
Labels
Milestone

Comments

@Biacco42
Copy link

I'm opening this issue because:

  • I'll report a bug
  • I'll propose a new feature

Description

open / tab-open console gets slowing when query string is longer than 3 ~ 4 characters.
IME (Google Japanese Input) also slows down.

Failure Information (for bugs)

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. hit "t" / "o" or ":tabopen" / ":open"
  2. type some character
  3. over 3 or more characters causes the issue

System configuration

  • Operating system: Mac OS 10.12.6
  • Firefox version: 57.0
  • Vim-Vixen version: 0.5

Console logs

Any relevant log in developer tools:
N/A

@ueokande ueokande added the bug label Nov 15, 2017
@make-github-pseudonymous-again

Culprit is here.

@make-github-pseudonymous-again

It seems the only part actually depending on the keyword is the API call to browser.history.search, assuming longer keywords return less results. Looks difficult to do better. Maybe delaying the search while the user is typing would be a first fix (I do not see it done anywhere at the moment).

@make-github-pseudonymous-again

I was wrong. There does seem to be another place depending on the length of the keyword(s).

@make-github-pseudonymous-again

Ok that one only loops through the search engines from the configuration and should not be too slow.

@sukima
Copy link

sukima commented Nov 1, 2018

It has been a year, Has there been any progress on this? It is really affecting the ability to type in the VimVixen console line. Without a fix in sight I'm close to dropping this addon. I did attempt to look at the source but the current abstractions in use are not making much sense. Is there some documentation on how that command line functions (Design Specs)?

@awu0012
Copy link

awu0012 commented Nov 6, 2018

@sukima feel free to take a look at awu0012@c0fb340

not a javascript programmer by any means, but it works for me

@ueokande ueokande added this to the 0.28 milestone Feb 22, 2020
@ueokande
Copy link
Owner

I have started to use Vim Vixen on macOS recently, and I encounter the same issue. It might be a particular problem with macOS. We need to research more on this issue.

@ueokande
Copy link
Owner

fixed in #1099

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants