extension-redis: fixes a bug that caused document updates to cause an… #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…other full sync once applied
janthurau
force-pushed
the
bug/redis-extension-duplicated-messages
branch
from
06b3878
to
8439c88
Compare
janthurau
added a commit
that referenced
this pull request
Oct 19, 2023
janthurau
added a commit
that referenced
this pull request
Oct 19, 2023
TalhaASiddiqi
pushed a commit
to educative/hocuspocus
that referenced
this pull request
Feb 1, 2024
…oming via redis, we shouldnt run onStoreDocument hooks; refs ueberdosis#730, refs ueberdosis#696, refs ueberdosis#606 (ueberdosis#733)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When applying an update incoming via redis, we unexpectedly triggered
onChange, which then triggered another full sync. This caused eight messages to be exchanged via redis per change. With this fix merged, it will be just four.