-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connection
can be either Connection or ConnectionConfiguration
#606
Labels
Comments
I should add some context. I need to access the Connection object from the (At an even higher level of context: I am trying to add a custom "awareness" implementation, and need access to the websocket directly). |
janthurau
added a commit
that referenced
this issue
Oct 19, 2023
janthurau
added a commit
that referenced
this issue
Oct 19, 2023
Open
TalhaASiddiqi
pushed a commit
to educative/hocuspocus
that referenced
this issue
Feb 1, 2024
…oming via redis, we shouldnt run onStoreDocument hooks; refs ueberdosis#730, refs ueberdosis#696, refs ueberdosis#606 (ueberdosis#733)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The problem I am facing
It's a bit confusing that there is a
connection
key in various hook payloads that is either aConnection
instance or aConnectionConfiguration
object. Both are quite different:Connection
ConnectionConfiguration
But they appear to be the same at first glance:
The solution I would like
It would be great if
ConnectionConfiguration
were alwaysconnectionConfig
andConnection
were alwaysconnection
.The text was updated successfully, but these errors were encountered: