Skip to content

Commit

Permalink
fixes ueberdosis#730: Reverts breaking change: When the update is inc…
Browse files Browse the repository at this point in the history
…oming via redis, we shouldnt run onStoreDocument hooks; refs ueberdosis#730, refs ueberdosis#696, refs ueberdosis#606 (ueberdosis#733)
  • Loading branch information
janthurau authored and TalhaASiddiqi committed Feb 1, 2024
1 parent 6c0ffe8 commit f206c5a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion packages/server/src/Hocuspocus.ts
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,8 @@ export class Hocuspocus {
// If the update was received through other ways than the
// WebSocket connection, we don’t need to feel responsible for
// storing the content.
if (!connection) {
// also ignore changes incoming through redis connection, as this would be a breaking change (#730, #696, #606)
if (!connection || (connection as unknown as string) === '__hocuspocus__redis__origin__') {
return
}

Expand Down

0 comments on commit f206c5a

Please sign in to comment.