Skip to content

refactor(vscode, language-server): remove hybrid mode configuration#5248

Merged
johnsoncodehk merged 8 commits intomasterfrom
remove-hybrid-mode-config
Mar 5, 2025
Merged

refactor(vscode, language-server): remove hybrid mode configuration#5248
johnsoncodehk merged 8 commits intomasterfrom
remove-hybrid-mode-config

Conversation

@johnsoncodehk
Copy link
Copy Markdown
Member

@johnsoncodehk johnsoncodehk commented Mar 4, 2025

As part of the 3.0 refactoring, the VSCode extension and language server no longer provide a configuration option to disable hybrid mode, which greatly reduces the amount of code to maintain, and this reduces the need for fs hacks on the typescript-language-features code. Our ultimate goal is to eliminate the need for fs hacks altogether, so this is an important progress.

Since language-server only works with typescript-plugin now, the test infrastructure needs to be refactored to run against @vue/typescript-plugin, which we do based on typescript-server-harness.

The test time has increased considerably for the time being, and this will be addressed in #5252 that removes the named pipe.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Mar 4, 2025

Open in Stackblitz

vue-component-meta

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-meta@5248

vue-component-type-helpers

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@5248

@vue/language-core

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-core@5248

@vue/language-plugin-pug

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@5248

@vue/language-server

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-server@5248

vue-tsc

npm i https://pkg.pr.new/vuejs/language-tools/vue-tsc@5248

@vue/language-service

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-service@5248

@vue/typescript-plugin

npm i https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@5248

commit: 7e6a485

@johnsoncodehk johnsoncodehk marked this pull request as ready for review March 5, 2025 07:42
@johnsoncodehk johnsoncodehk changed the title refactor: remove hybrid mode configuration refactor(vscode, language-server): remove hybrid mode configuration Mar 5, 2025
@johnsoncodehk johnsoncodehk merged commit dac1089 into master Mar 5, 2025
@johnsoncodehk johnsoncodehk deleted the remove-hybrid-mode-config branch March 5, 2025 07:57
Comment thread packages/language-server/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants