Revert "Fix "Create profile" page not supporting dark mode (#8110)" #9201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR reverts dark mode support changes for the "Create profile" page and workspace member default color scheme due to sync-metadata functionality issues.
- Changed default
colorSchemefrom 'System' to 'Light' in/packages/twenty-server/src/modules/workspace-member/standard-objects/workspace-member.workspace-entity.ts - Reverted dark mode support in
/packages/twenty-server/src/engine/core-modules/user-workspace/user-workspace.service.tscreateWorkspaceMember method - Changes will be re-implemented after version 0.35 to resolve sync-metadata compatibility issues
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
samyakpiya
pushed a commit
to samyakpiya/twenty
that referenced
this pull request
Dec 28, 2024
…8110)" (twentyhq#9201) Reverts twentyhq#9185 This PR breaks sync-metadata, will merge back after 0.35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #9185
This PR breaks sync-metadata, not supporting defaultValue changes with TEXT type. Will merge back after 0.35