Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

White Create profile page despite dark system settings #8110

Closed
BOHEUS opened this issue Oct 26, 2024 · 1 comment
Closed

White Create profile page despite dark system settings #8110

BOHEUS opened this issue Oct 26, 2024 · 1 comment
Assignees
@eliasylonen
Labels
for experienced contributor scope: front Issues that are affecting the frontend side only size: short type: design improvement

Comments

@BOHEUS
Copy link
Contributor

BOHEUS commented Oct 26, 2024

Scenario:

  1. Set dark theme in OS or browser
  2. Create new account

Actual: Create profile page is white despite other pages being dark
Screencast From 2024-10-26 22-18-16.webm

Expected: Create profile page should respect OS theme settings like other pages
@BKM14
Copy link
Contributor

BKM14 commented Oct 27, 2024

Hey @BOHEUS, I think I have figured out the issue. We are only updating the colorScheme of the currentWorkspaceMember. This implies that the colorScheme applies to all the following steps, but not for the current step as it is called only when the submit button is clicked.

An ideal solution would be to set the colorScheme of the currentWorkspaceMember in the choose your plan section itself. What is your opinion?
Also, how can I access the choose plan section locally? It redirects to the next step always.

image

@BOHEUS BOHEUS mentioned this issue Dec 7, 2024
Closed
@eliasylonen eliasylonen mentioned this issue Dec 22, 2024
Merged
FelixMalfait pushed a commit that referenced this issue Dec 23, 2024
@eliasylonen @ad-elias
Fix "Create profile" page not supporting dark mode (#8110) (#9185)
7d57d61 
Fixes issue #8110

Co-authored-by: ad-elias <[email protected]>
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Product development ✅ Dec 23, 2024
Weiko added a commit that referenced this issue Dec 23, 2024
@Weiko
Revert "Fix "Create profile" page not supporting dark mode (#8110) (#…
47df1de 
…9185)"

This reverts commit 7d57d61.
Weiko added a commit that referenced this issue Dec 23, 2024
@Weiko
Revert "Fix "Create profile" page not supporting dark mode (#8110)" (#…
c947040 
…9201)

Reverts #9185
This PR breaks sync-metadata, will merge back after 0.35
Weiko added a commit that referenced this issue Dec 23, 2024
@Weiko
Revert "Revert "Fix "Create profile" page not supporting dark mode (#…
07c0624 
…8110)" (…"

This reverts commit c947040.
Weiko added a commit that referenced this issue Dec 24, 2024
@Weiko
Restore "Fix "Create profile" page not supporting dark mode (#8110)" …
2dcfaea 
…& Fix string defaultValues during sync-metadata (#9220)

Restoring #9185
Also fixing sync-metadata with test values in jsonb

## Test
sync-metadata on existing workspaces should replace colorSchema in both
metadata and workspaceMember tables
samyakpiya pushed a commit to samyakpiya/twenty that referenced this issue Dec 28, 2024
@eliasylonen @ad-elias @samyakpiya
Fix "Create profile" page not supporting dark mode (twentyhq#8110) (t…
80a19ae 
…wentyhq#9185)

Fixes issue twentyhq#8110

Co-authored-by: ad-elias <[email protected]>
samyakpiya pushed a commit to samyakpiya/twenty that referenced this issue Dec 28, 2024
@Weiko @samyakpiya
Revert "Fix "Create profile" page not supporting dark mode (twentyhq#…
43751c8 
…8110)" (twentyhq#9201)

Reverts twentyhq#9185
This PR breaks sync-metadata, will merge back after 0.35
samyakpiya pushed a commit to samyakpiya/twenty that referenced this issue Dec 28, 2024
@Weiko @samyakpiya
Restore "Fix "Create profile" page not supporting dark mode (twentyhq…
c883338 
…#8110)" & Fix string defaultValues during sync-metadata (twentyhq#9220)

Restoring twentyhq#9185
Also fixing sync-metadata with test values in jsonb

## Test
sync-metadata on existing workspaces should replace colorSchema in both
metadata and workspaceMember tables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eliasylonen eliasylonen

Labels
for experienced contributor scope: front Issues that are affecting the frontend side only size: short type: design improvement
Projects
Product development ✅
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@eliasylonen @FelixMalfait @Bonapara @BOHEUS @BKM14