Fix "Create profile" page not supporting dark mode (#8110) #9185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Changes the default color scheme for workspace members from 'Light' to 'System' to respect system dark mode settings during user onboarding.
- Modified default color scheme value to 'System' in
workspace-member.workspace-entity.ts - Updated SQL INSERT statement in
user-workspace.service.tsto use 'System' as default color scheme - Ensures 'Create profile' page respects system dark mode preferences during account creation
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
FelixMalfait
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Thanks!
@Bonapara fyi - means more people will be using dark mode
|
Thanks @eliasylonen for your contribution! |
Weiko
added a commit
that referenced
this pull request
Dec 23, 2024
Weiko
added a commit
that referenced
this pull request
Dec 23, 2024
samyakpiya
pushed a commit
to samyakpiya/twenty
that referenced
this pull request
Dec 28, 2024
…wentyhq#9185) Fixes issue twentyhq#8110 Co-authored-by: ad-elias <[email protected]>
samyakpiya
pushed a commit
to samyakpiya/twenty
that referenced
this pull request
Dec 28, 2024
…8110)" (twentyhq#9201) Reverts twentyhq#9185 This PR breaks sync-metadata, will merge back after 0.35
samyakpiya
pushed a commit
to samyakpiya/twenty
that referenced
this pull request
Dec 28, 2024
…#8110)" & Fix string defaultValues during sync-metadata (twentyhq#9220) Restoring twentyhq#9185 Also fixing sync-metadata with test values in jsonb ## Test sync-metadata on existing workspaces should replace colorSchema in both metadata and workspaceMember tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #8110