Fix seeds #7543
Merged
Fix seeds #7543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ijreilly
commented
Oct 9, 2024
•
ijreilly
commented
- Fixing seeds after introducing the requirement for non-nullable fields to have a default value ([fix] Nullable fields must have default values #7522).
- Empty string needs to be considered a valid default value
charlesBochet
approved these changes
Oct 9, 2024
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses seed data and field validation issues in the Twenty application. Here's a concise summary of the key changes:
- Updated seed data for company and people custom fields in
fieldsMetadata.ts- Added default value for 'tagline' field in company custom fields
- Changed 'isNullable' property of 'whatsapp' field in people custom fields to true
- Improved non-nullable field validation in
field-metadata.service.ts- Imported
isDefinedfunction for more accurate checks - Updated
validateFieldMetadataInputmethod to useisDefinedfor default value validation
- Imported
- These changes enhance data consistency and prevent potential validation errors for falsy values
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| @@ -15,6 +15,7 @@ export const getDevSeedCompanyCustomFields = ( | |||
| icon: 'IconAdCircle', | |||
| isActive: true, | |||
| isNullable: false, | |||
| defaultValue: "''", | |||
There was a problem hiding this comment.
logic: The default value for 'tagline' is set to an empty string. Ensure this is the intended behavior and doesn't conflict with the 'isNullable: false' setting.
Weiko
approved these changes
Oct 9, 2024
| @@ -98,7 +99,7 @@ export const getDevSeedPeopleCustomFields = ( | |||
| description: "Contact's Whatsapp Number", | |||
| icon: 'IconBrandWhatsapp', | |||
| isActive: true, | |||
| isNullable: false, | |||
| isNullable: true, | |||
There was a problem hiding this comment.
could remain false since you set a default value? up to you!
Merged
ijreilly
added a commit
that referenced
this pull request
Oct 10, 2024
In [this](#7522) and [this](#7543) PR we introduced the impossibility to save a field that would be non nullable but without a default value. The check is actually called on the input while the defaultValue is added by the service on a "built" fieldMetadata to create or save. So far all fields created from the app it currently fails as both isNullable and defaultValue are undefined so falsy at that stage.
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
- Fixing seeds after introducing the requirement for non-nullable fields to have a default value (twentyhq#7522). - Empty string needs to be considered a valid default value
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
In [this](twentyhq#7522) and [this](twentyhq#7543) PR we introduced the impossibility to save a field that would be non nullable but without a default value. The check is actually called on the input while the defaultValue is added by the service on a "built" fieldMetadata to create or save. So far all fields created from the app it currently fails as both isNullable and defaultValue are undefined so falsy at that stage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.