Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix seeds #7543

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Fix seeds #7543

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5a55d5
Fix seed
ijreilly Oct 9, 2024
1967d07
add default value to seeds
ijreilly Oct 9, 2024
e56fc61
Merge branch 'main' of github.com:twentyhq/twenty into fix-seeds
ijreilly Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/twenty-server/src/database/typeorm-seeds/metadata/fieldsMetadata.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ export const getDevSeedCompanyCustomFields = (
icon: 'IconAdCircle',
isActive: true,
isNullable: false,
defaultValue: "''",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: The default value for 'tagline' is set to an empty string. Ensure this is the intended behavior and doesn't conflict with the 'isNullable: false' setting.

objectMetadataId,
},
{
Expand Down Expand Up @@ -98,7 +99,7 @@ export const getDevSeedPeopleCustomFields = (
description: "Contact's Whatsapp Number",
icon: 'IconBrandWhatsapp',
isActive: true,
isNullable: false,
isNullable: true,
Copy link
Member

@Weiko Weiko Oct 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could remain false since you set a default value? up to you!

objectMetadataId,
},
{
Expand Down
3 changes: 2 additions & 1 deletion packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ import { TwentyORMGlobalManager } from 'src/engine/twenty-orm/twenty-orm-global.
import { computeObjectTargetTable } from 'src/engine/utils/compute-object-target-table.util';
import { WorkspaceMigrationRunnerService } from 'src/engine/workspace-manager/workspace-migration-runner/workspace-migration-runner.service';
import { ViewFieldWorkspaceEntity } from 'src/modules/view/standard-objects/view-field.workspace-entity';
import { isDefined } from 'src/utils/is-defined';

import { FieldMetadataValidationService } from './field-metadata-validation.service';
import {
Expand Down Expand Up @@ -746,7 +747,7 @@ export class FieldMetadataService extends TypeOrmQueryService<FieldMetadataEntit
}

if (!fieldMetadataInput.isNullable) {
if (!fieldMetadataInput.defaultValue) {
if (!isDefined(fieldMetadataInput.defaultValue)) {
throw new FieldMetadataException(
'Default value is required for non nullable fields',
FieldMetadataExceptionCode.INVALID_FIELD_INPUT,
Expand Down
Loading