[fix] Nullable fields must have default values #7522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request adds a validation check to ensure non-nullable fields have default values in the FieldMetadataService class.
- Added validation in
validateFieldMetadataInputmethod to require default values for non-nullable fields - The change improves data integrity but may have implications for existing fields and data
- Consider adding a migration strategy for existing non-nullable fields without default values
- Evaluate the impact on API consumers and client-side applications that may need to adapt to this new requirement
- Review error handling and messaging to provide clear guidance for users encountering this validation
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
Comment on lines
748
to
755
| if (!fieldMetadataInput.isNullable) { | ||
| if (!fieldMetadataInput.defaultValue) { | ||
| throw new FieldMetadataException( | ||
| 'Default value is required for nullable fields', | ||
| FieldMetadataExceptionCode.INVALID_FIELD_INPUT, | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
logic: The condition and error message are inconsistent. It checks for non-nullable fields but the error message mentions nullable fields. This needs to be corrected.
Comment on lines
748
to
755
| if (!fieldMetadataInput.isNullable) { | ||
| if (!fieldMetadataInput.defaultValue) { | ||
| throw new FieldMetadataException( | ||
| 'Default value is required for nullable fields', | ||
| FieldMetadataExceptionCode.INVALID_FIELD_INPUT, | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
style: This validation might be too strict. Some field types might not require a default value even if they're non-nullable (e.g., auto-incrementing IDs).
Merged
charlesBochet
pushed a commit
that referenced
this pull request
Oct 9, 2024
- Fixing seeds after introducing the requirement for non-nullable fields to have a default value (#7522). - Empty string needs to be considered a valid default value
Merged
ijreilly
added a commit
that referenced
this pull request
Oct 10, 2024
In [this](#7522) and [this](#7543) PR we introduced the impossibility to save a field that would be non nullable but without a default value. The check is actually called on the input while the defaultValue is added by the service on a "built" fieldMetadata to create or save. So far all fields created from the app it currently fails as both isNullable and defaultValue are undefined so falsy at that stage.
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
- Fixing seeds after introducing the requirement for non-nullable fields to have a default value (twentyhq#7522). - Empty string needs to be considered a valid default value
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
In [this](twentyhq#7522) and [this](twentyhq#7543) PR we introduced the impossibility to save a field that would be non nullable but without a default value. The check is actually called on the input while the defaultValue is added by the service on a "built" fieldMetadata to create or save. So far all fields created from the app it currently fails as both isNullable and defaultValue are undefined so falsy at that stage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.